Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Social Icons using AMP and WP 5.0.x #10973

Closed
allen-mckenzie opened this issue Dec 13, 2018 · 4 comments
Closed

Missing Social Icons using AMP and WP 5.0.x #10973

allen-mckenzie opened this issue Dec 13, 2018 · 4 comments
Assignees
@jeherve
Labels
AMP [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.9

Comments

@allen-mckenzie
Copy link

Describe the bug
There seems to be an issue with the recent changes in WP 5.0.1 with AMP and Jetpack's social sharing icons that causes them to no longer display.

To Reproduce
Steps to reproduce the behavior:

  1. Scroll down to the bottom of the post where the social sharing links are
  2. See error

Expected behavior
Social Sharing icons should be displayed instead of basic ul li list

Screenshots
screenshot

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 70.0.3538.110
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended AMP labels Dec 13, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 13, 2018
@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 13, 2018
@jeherve
Copy link
Member

jeherve commented Dec 13, 2018

Thanks for the report! Is there any chance you could post a link to one of the pages where you see the issue, so we can take a closer look?

Could you also let me know if you use the latest version of the AMP plugin, 1.0.1, and not another AMP plugin?

Thank you.

@allen-mckenzie
Copy link
Author

Latest version of the AMP plugin but this was discovered on a staging server so I don't have an example other than my screenshot that I can provide.

@davebonds
Copy link

It is happening on the latest version of the official AMP plugin https://wordpress.org/plugins/amp/ and latest Jetpack 6.8.1 on WP 5.0.1

@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 14, 2018
@jeherve
Copy link
Member

jeherve commented Dec 14, 2018

Thank you both for the replies. This will be fixed by #10945

@gravityrail gravityrail mentioned this issue Dec 14, 2018
Merged
@jeherve jeherve self-assigned this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
AMP [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.9
Development

No branches or pull requests
3 participants
@davebonds @jeherve @allen-mckenzie