Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery: editor drops ssl=1 from Photon URLs #12199

Open
simison opened this issue Apr 29, 2019 · 2 comments
Open

Tiled gallery: editor drops ssl=1 from Photon URLs #12199

simison opened this issue Apr 29, 2019 · 2 comments
Assignees
@simison
Labels
[Block] Tiled Gallery [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended

Comments

@simison
Copy link
Member

simison commented Apr 29, 2019 •
edited
Loading

Photon URLs need ssl=1 URL attribute in them to differentiate between https and http URLs. Without it, Photon might need to do an extra redirect when fetching the photo.

Blocks' editor implementation is dropping this argument from image URLs.

Via #11397 (comment)

Convo p1556564136168700-slack-jetpack-gutenberg
@simison simison added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 29, 2019
@simison simison mentioned this issue Apr 29, 2019
Merged
@sirreal
Copy link
Member

sirreal commented Apr 30, 2019

I haven't observed this, I've just tested with a new site running master.

@kraftbj can you provide details on how to reproduce this? Do a specific set of modules need to be enabled?

@sirreal sirreal removed their assignment May 22, 2019
@sirreal sirreal added the [Status] Needs Testing We need to add this change to the testing call for this month's release label May 22, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Nov 25, 2019
@samiff samiff removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simison simison

Labels
[Block] Tiled Gallery [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@simison @jeherve @sirreal @samiff