Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.3 Compatibility #13597

Closed
11 tasks done
jeherve opened this issue Sep 30, 2019 · 6 comments
Closed
11 tasks done

WordPress 5.3 Compatibility #13597

jeherve opened this issue Sep 30, 2019 · 6 comments
Assignees
@jeherve
Labels
Epic Formerly "Primary Issue", or "Master Issue" General [Pri] BLOCKER [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
7.9

Comments

@jeherve
Copy link
Member

jeherve commented Sep 30, 2019 •
edited
Loading

WordPress 5.3 is currently scheduled to ship November 12 2019, and will include changes that we should aim to support in Jetpack.

I am creating this Master Issue to help me keep track of all those changes:
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it General Epic Formerly "Primary Issue", or "Master Issue" [Pri] BLOCKER labels Sep 30, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 30, 2019
@jeherve jeherve self-assigned this Sep 30, 2019
@simison
Copy link
Member

simison commented Oct 9, 2019

Might need reviewing: https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/

@jeherve jeherve mentioned this issue Oct 9, 2019
Closed
@jeherve
Copy link
Member Author

jeherve commented Oct 9, 2019

@simison Good Call. Noted in #13694

@kraftbj kraftbj mentioned this issue Oct 10, 2019
Open
@kraftbj
Copy link
Contributor

kraftbj commented Oct 10, 2019

Only slightly related but we can get a tiny performance boost by using the spread operator ourselves: #13699

The most gain would be to XML-RPC but we can't optimize that until Core does since we extend their IXR classes.

@simison
Copy link
Member

simison commented Oct 10, 2019

Is this listenTo affected by https://make.wordpress.org/core/2019/10/10/wordpress-5-3-backbone-upgrade-guide/?

@jeherve
Copy link
Member Author

jeherve commented Oct 10, 2019

@simison No, it seems okay in my tests. 👍

@jeherve jeherve mentioned this issue Oct 10, 2019
Closed
@jeherve
Copy link
Member Author

jeherve commented Oct 15, 2019

https://make.wordpress.org/core/2019/10/15/changes-to-wp_die-html-output-in-wordpress-5-3/

With WordPress 5.3, error messages are wrapped in a <div> rather than a <p>

This doesn't seem to impact us. 👍

@jeherve jeherve closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
Epic Formerly "Primary Issue", or "Master Issue" General [Pri] BLOCKER [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

No branches or pull requests
3 participants
@simison @kraftbj @jeherve