Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Map block - fix close icon alignment #13647

Closed
joanrho opened this issue Oct 3, 2019 · 0 comments · Fixed by #13649
Closed

Jetpack Map block - fix close icon alignment #13647

joanrho opened this issue Oct 3, 2019 · 0 comments · Fixed by #13649
Assignees
@joanrho
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
7.9

Comments

@joanrho
Copy link
Contributor

joanrho commented Oct 3, 2019

Breaking this one out of @simison's original mega-issue #13618 that lists out several visual regressions so we can tackle them one by one in separate PRs.

The close icon in the top right of the map marker popover has a close icon that isn't properly aligned. The text “Add a location” has a margin of 0.5rem, but that looked a bit too much for the close icon. Adding 0.4rem (only to the top) of the close icon felt optically right.

Before/After:
Screen Shot 2019-10-03 at 4 19 20 PM
@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Design has been added. Needs a review! [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 3, 2019
@joanrho joanrho added this to the 7.9 milestone Oct 3, 2019
@joanrho joanrho self-assigned this Oct 3, 2019
@joanrho joanrho mentioned this issue Oct 3, 2019
Merged
@simison simison mentioned this issue Oct 4, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanrho joanrho

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging a pull request may close this issue.

Jetpack Map block - fix close icon alignment in add location popover Automattic/jetpack
1 participant
@joanrho