Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Search: query params get cleared when the search is exited. #13808

Closed
gibrown opened this issue Oct 22, 2019 · 3 comments · Fixed by #13825
Closed

Instant Search: query params get cleared when the search is exited. #13808

gibrown opened this issue Oct 22, 2019 · 3 comments · Fixed by #13825
Assignees
@jsnmoon
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended

Comments

@gibrown
Copy link
Member

gibrown commented Oct 22, 2019

Steps to reproduce the issue

  1. Follow instructions in Instant Search: Update prototype with downstream changes #13761 to get search running
  2. Load the home page with a query param in the url (does not need to do anything)
  3. Run a search
  4. Clear the search

The query param gets removed.
@gibrown gibrown added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search Instant Search labels Oct 22, 2019
@gibrown gibrown mentioned this issue Oct 22, 2019
Merged
@jsnmoon jsnmoon self-assigned this Oct 23, 2019
@jsnmoon jsnmoon mentioned this issue Oct 23, 2019
Merged
@gibrown
Copy link
Member Author

gibrown commented Oct 25, 2019

This doesn't seem to be fixed for me on http://gibrown.wpsandbox.me/demo/ (currently running master).

@gibrown gibrown reopened this Oct 25, 2019
@gibrown gibrown added this to the 7.9 milestone Oct 25, 2019
@jsnmoon
Copy link
Member

jsnmoon commented Oct 25, 2019

@gibrown That's a different bug -- this bug relates to the initial query parameter being removed; the bug affecting the above link removes the pathname when appending a query string to the URL.

Working on a fix now. Could we track this in a separate issue, please?

@jsnmoon jsnmoon removed this from the 7.9 milestone Oct 25, 2019
@jsnmoon
Copy link
Member

jsnmoon commented Oct 25, 2019 •
edited
Loading

The new issue is now being tracked in #13845.

@jsnmoon jsnmoon closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnmoon jsnmoon

Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Instant Search: Use href to restore previous location state Automattic/jetpack
2 participants
@gibrown @jsnmoon