Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Search: Load more button not displayed when sorting by newest/oldest #13809

Closed
gibrown opened this issue Oct 22, 2019 · 1 comment
Closed

Instant Search: Load more button not displayed when sorting by newest/oldest #13809

gibrown opened this issue Oct 22, 2019 · 1 comment
Assignees
@gibrown @jsnmoon
Labels
[Feature] Search For all things related to Search [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone
7.9

Comments

@gibrown
Copy link
Member

gibrown commented Oct 22, 2019

Steps to reproduce the issue

  1. Follow instructions in Instant Search: Update prototype with downstream changes #13761 to get search running
  2. Run a search... there is a load more button at the bottom
  3. Sort by newest or oldest and there will be no load more button

This is maybe an API bug as we seem to be returning false with the page handle
@gibrown gibrown added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search Instant Search [Pri] High labels Oct 22, 2019
@gibrown gibrown mentioned this issue Oct 22, 2019
Merged
@gibrown gibrown added this to the 7.9 milestone Oct 25, 2019
@gibrown
Copy link
Member Author

gibrown commented Oct 28, 2019

This is fixed in r198541. Was an API issue

@gibrown gibrown closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibrown gibrown

@jsnmoon jsnmoon

Labels
[Feature] Search For all things related to Search [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

No branches or pull requests
2 participants
@gibrown @jsnmoon