Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Search: Non-English taxonomy filter is encoded #13812

Closed
gibrown opened this issue Oct 22, 2019 · 5 comments
Closed

Instant Search: Non-English taxonomy filter is encoded #13812

gibrown opened this issue Oct 22, 2019 · 5 comments
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended

Comments

@gibrown
Copy link
Member

gibrown commented Oct 22, 2019

Steps to reproduce the issue

  1. Follow instructions in Instant Search: Update prototype with downstream changes #13761 to get search running
  2. Configure a taxonomy filter for language on wordpress.tv
  3. Load up the filters and you will see:

Screen Shot 2019-10-22 at 2 06 12 PM

@gibrown gibrown added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search Instant Search labels Oct 22, 2019
@bluefuton
Copy link
Contributor

Is the plan to fix this encoding in the endpoint, or do we want to do it on the client side?

@gibrown
Copy link
Member Author

gibrown commented Oct 23, 2019

I was thinking in the client, but I really haven't looked at exactly what is coming from the API and ES.

@jsnmoon
Copy link
Member

jsnmoon commented Oct 28, 2019

I think the correct approach would be to correct this in the API.

In an ideal world, the above screenshot might look like the following:

  • english should be English, or English (American)
  • spanishespanol should be Spanish (Español)
  • germandeutsch should be German (Deutsch)
  • frenchfrancais should be French (Français)
  • japanese%e6%97%a5%e6%9c%ac%e8%aa%9e should be Japanese (日本語)

Screen Shot 2019-10-28 at 1 04 26 PM

@bluefuton
Copy link
Contributor

@jsnmoon
Copy link
Member

jsnmoon commented Jan 28, 2020

Fixed in #14437.

@jsnmoon jsnmoon closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants