Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Backup: implement code style improvements #14065

Closed
5 tasks
robertf4 opened this issue Nov 18, 2019 · 2 comments · Fixed by #14961
Closed
5 tasks

Jetpack Backup: implement code style improvements #14065

robertf4 opened this issue Nov 18, 2019 · 2 comments · Fixed by #14961
Assignees
@robertf4
Labels
Admin Page React-powered dashboard under the Jetpack menu Plans [Pri] Normal [Type] Janitorial

Comments

@robertf4
Copy link
Contributor

robertf4 commented Nov 18, 2019 •
edited by tyxla
Loading

I'm creating this to keep track of the feedback on #14056 that needs to be addressed.

  • Do not pass entire backupPlanPrices prop object to SingleProductBackupBody
  • Make the appropriate propTypes required
  • Do not define backupOptions or upgradeTitles on render
  • Split single-product-backup.jsx into multiple files
  • Rename PlanPriceDisplay to be more specific
@robertf4 robertf4 mentioned this issue Nov 18, 2019
Merged
@robertf4 robertf4 self-assigned this Nov 18, 2019
@jeherve jeherve added [Pri] Normal [Type] Janitorial Admin Page React-powered dashboard under the Jetpack menu Plans labels Nov 18, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 18, 2019
@delawski
Copy link
Contributor

@robertf4 @jeherve It seems that most if not all of the issues here have been resolved. Is it correct?

@tyxla
Copy link
Member

tyxla commented Nov 29, 2019

Some haven't been resolved yet, I'll move this to the next release as these are not blockers at all.

@tyxla tyxla modified the milestones: 8.0, 8.1 Nov 29, 2019
@jeherve jeherve removed this from the 8.1 milestone Dec 20, 2019
@jsnmoon jsnmoon mentioned this issue Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertf4 robertf4

Labels
Admin Page React-powered dashboard under the Jetpack menu Plans [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetpack Backup: Refactor component into multiple modules Automattic/jetpack
4 participants
@jeherve @delawski @tyxla @robertf4