Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharedaddy: Fatal Error when is_protected_meta is only called with two arguments. #14216

Closed
akirk opened this issue Dec 12, 2019 · 0 comments · Fixed by #14218
Closed

Sharedaddy: Fatal Error when is_protected_meta is only called with two arguments. #14216

akirk opened this issue Dec 12, 2019 · 0 comments · Fixed by #14218
Assignees
@akirk
Labels
[Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.1

Comments

@akirk
Copy link
Member

akirk commented Dec 12, 2019

Steps to reproduce the issue

Thrive Architect in version 2.4.6 triggers the is_protected_meta hook with just two arguments. The docs seem a bit ambiguous to me:

apply_filters( 'is_protected_meta', bool $protected, string $meta_key, string|null $meta_type )

So they interpreted the last argument as optional, we expect three → Fatal Error.
@akirk akirk mentioned this issue Dec 12, 2019
Merged
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons labels Dec 12, 2019
@jeherve jeherve added this to the 8.1 milestone Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akirk akirk

Labels
[Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Only use two arguments of is_protected_meta Automattic/jetpack
2 participants
@akirk @jeherve