Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendly Block: add default customTextButtonColor and customBackgroundButtonColor to avoid notices #14368

Closed
jeherve opened this issue Jan 16, 2020 · 0 comments · Fixed by #14369
Closed

Calendly Block: add default customTextButtonColor and customBackgroundButtonColor to avoid notices #14368

jeherve opened this issue Jan 16, 2020 · 0 comments · Fixed by #14369
Labels
[Block] Calendly [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.2

Comments

@jeherve
Copy link
Member

jeherve commented Jan 16, 2020

When opening the editor for a post that has a Calendly block, I currently get the following notices:

Notice: Undefined index: customTextButtonColor in wp-content/plugins/jetpack-dev/extensions/blocks/calendly/calendly.php on line 122
Notice: Undefined index: customBackgroundButtonColor in wp-content/plugins/jetpack-dev/extensions/blocks/calendly/calendly.php on line 122

I think we'd need to add defaults for those values as well to avoid those notices.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Block] Calendly labels Jan 16, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 16, 2020
@scruffian scruffian mentioned this issue Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Calendly [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.2
Development

Successfully merging a pull request may close this issue.

Calendly: Prevent notices for undefined attributes Automattic/jetpack
1 participant
@jeherve