-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant Search: Early Design Feedback #14453
Comments
Related: #14306 |
This is being added as part of this PR: #14423 |
I think that's something we'll have to accept since the overlay is inheriting styles from the base theme. Undeniably some will look better than others, but my best guess is that the minute we impose some harsher rules for all themes is the moment we'll break compatibility with some of them. I do think we should keep logging these to evaluate if it's a bigger problem than assumed initially. |
What browser is this in @gibrown? I wonder if we can prevent it by disabling search inputs that aren't in the overlay when the overlay is open. |
Should be fixed in #14493. |
I'm using Chrome. |
@keoshi adding to this I was playing around with mobile and had a few questions:
|
Broke all of these out into separate issues so we can separately prioritize them. |
I went through and tested a bunch of themes and took some notes. Some of these are bugs and some of these are more questions/opinions. If you think something is done/addressed/etc, then just check it off. Some of these may already be obvious, but when I wasn't sure I added them to the list.
The text was updated successfully, but these errors were encountered: