Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Search: Fix up theme issues #14610

Closed
4 tasks done
gibrown opened this issue Feb 8, 2020 · 4 comments
Closed
4 tasks done

Instant Search: Fix up theme issues #14610

gibrown opened this issue Feb 8, 2020 · 4 comments
Assignees
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended

Comments

@gibrown
Copy link
Member

gibrown commented Feb 8, 2020

@gibrown gibrown added [Feature] Search For all things related to Search Instant Search labels Feb 8, 2020
@gibrown gibrown added this to the InstantSearchLaunch milestone Feb 8, 2020
@gibrown gibrown added the [Type] Bug When a feature is broken and / or not performing as intended label Feb 8, 2020
@keoshi keoshi self-assigned this Feb 12, 2020
@keoshi
Copy link
Contributor

keoshi commented Feb 13, 2020

  • storefront theme (the default for all WooCommerce), has a number of broken styling details

Do you remember what these were, @gibrown ? I can only see the poor legibility on the widget titles here:

image

If that's it, I think that a good case to extend a similar solution to what I proposed on #14666 to a few elements, which also applies to the second bullet point on this issue.

@keoshi
Copy link
Contributor

keoshi commented Feb 13, 2020

Addressed in #14669

@keoshi
Copy link
Contributor

keoshi commented Feb 13, 2020

@gibrown
Copy link
Member Author

gibrown commented Feb 24, 2020

I think all of the storefront stuff has now been fixed by the styling changes for the search box, close button, etc.

@gibrown gibrown closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants