Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravatar Hovercards Load When There Are No Gravatars #14860

Closed
josephscott opened this issue Mar 3, 2020 · 0 comments · Fixed by #14922
Closed

Gravatar Hovercards Load When There Are No Gravatars #14860

josephscott opened this issue Mar 3, 2020 · 0 comments · Fixed by #14922
Assignees
Labels
[Feature] Gravatar Hovercards [Focus] Performance [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@josephscott
Copy link
Contributor

Steps to reproduce the issue

  1. Setup Jetpack
  2. Enable Gravatar Hovercards
  3. View home page of site with just post content, no comments ( no Gravatars )
  4. See that all of the Gravatar Hovercards are still loaded

What I expected

I expect that the Gravatar Hovercards only get loaded on page views where there are going to be Gravatars, usually that would be for comments.

What happened instead

While viewing the front page of a site that showed no comment ( or Gravatars ), the resources for the Gravatar Hovercard feature was still being loaded. That means you pay the performance penalty for the feature, even when it can't be used.

I recently ran tests under slow mobile conditions and enabling Gravatar Hovercards increased the start render time by 21.4%. That may be fine on views where the feature is going to be used. On pages where the feature isn't used, that is pure overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Gravatar Hovercards [Focus] Performance [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants