Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premium block: "paid" word is off in the inserter #14977

Closed
simison opened this issue Mar 13, 2020 · 6 comments
Closed

Premium block: "paid" word is off in the inserter #14977

simison opened this issue Mar 13, 2020 · 6 comments
Assignees
Labels
[Block] Pay With Paypal aka Simple Payments [Block] Payment Button aka Recurring Payments [Feature] Pay with PayPal aka Simple Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@simison
Copy link
Member

simison commented Mar 13, 2020

When opening the block inserter via / in Gutenberg 7.7, the "paid" word seems to be off somehow:

Screenshot 2020-03-13 at 15 58 29

Screenshot 2020-03-13 at 15 57 18

Screenshot 2020-03-13 at 15 57 12

I don't know if this is a core Gutenberg issue or something in our block titles, but it's worth investigating.

Steps to reproduce the issue

  1. With Gutenberg 7.7 on WordPress.com free simple site, press /
  2. Observe paid plan names

cc @artpi @Automattic/ajax @Automattic/explorers

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended Simple Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Payment Button aka Recurring Payments labels Mar 13, 2020
@simison
Copy link
Member Author

simison commented Mar 13, 2020

Prolly something in core since I see the same problem in other menus with long texts:

image

@jeherve jeherve added this to the 8.4 milestone Mar 13, 2020
@Copons
Copy link
Contributor

Copons commented Mar 13, 2020

Yeah this must be something in Core, because we don't really do anything particular with the block names AFAIK.

Also for some reasons, in my test the second line gets slightly cut off (noticeable with the "p" in "paid"):
Screenshot 2020-03-13 at 15 37 12

@creativecoder
Copy link
Contributor

creativecoder commented Mar 17, 2020

@Automattic/explorers when you start this one, since it seems to be an issue with Core, please open an issue in Core, link to that issue here, and we'll solve it in Core, if possible.

@Copons
Copy link
Contributor

Copons commented Mar 17, 2020

I've opened a Core PR to address this: WordPress/gutenberg#20962

@Copons Copons self-assigned this Mar 17, 2020
@Copons
Copy link
Contributor

Copons commented Mar 19, 2020

Fixed by WordPress/gutenberg#20962 💃

@Copons Copons closed this as completed Mar 19, 2020
@simison
Copy link
Member Author

simison commented Mar 19, 2020

Thank you @Copons for jumping into it! 🙌

@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pay With Paypal aka Simple Payments [Block] Payment Button aka Recurring Payments [Feature] Pay with PayPal aka Simple Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants