Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Compatibility: Repeat Visitor Block styling issue with radio button in editor UI #19484

Closed
andrewserong opened this issue Apr 9, 2021 · 2 comments
Assignees
Labels
[Block] Repeat Visitor [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Type] Bug When a feature is broken and / or not performing as intended

Comments

@andrewserong
Copy link
Member

In the new site editor in Gutenberg (/wp-admin/admin.php?page=gutenberg-edit-site), there is a styling issue with the radio buttons within the Repeat Visitor Block's placeholder state.

Note: this is a similar issue to the radio button styling problem in the Latest Instagram Posts block: #19466

Steps to reproduce the issue

  1. With the Gutenberg plugin active (>=10.4.0-rc1), activate a block-ready theme (like tt1-blocks)
  2. In the site editor, insert a Repeat Visitor block into the Footer template part
  3. Observe that the radio button styling looks off compared to a normal site running Twenty Twenty theme

What I expected

For the radio buttons to be rendered correctly. For example:

image

What happened instead

The radio buttons render with the white circle in the wrong place:

image

@andrewserong andrewserong added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended [Block] Repeat Visitor [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg labels Apr 9, 2021
@andrewserong andrewserong self-assigned this Apr 14, 2021
@andrewserong
Copy link
Member Author

Tested and confirmed that this issue is resolved by the Gutenberg PR WordPress/gutenberg#30670 that adds in the correct box-sizing: inherit to get this working.

image

The fix will land in Gutenberg 10.5.

@andrewserong
Copy link
Member Author

Closing out this issue as it doesn't require any changes in the Jetpack repo (just beware that the issue will still display until GB 10.5 is released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Repeat Visitor [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

1 participant