Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Boost] Dynamically loaded images don't have an image guide #28344

Closed
dilirity opened this issue Jan 13, 2023 · 4 comments
Closed

[Boost] Dynamically loaded images don't have an image guide #28344

dilirity opened this issue Jan 13, 2023 · 4 comments
Assignees
Labels
[Platform] Simple [Plugin] Boost A feature to speed up the site and improve performance. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dilirity
Copy link
Member

Impacted plugin

Boost

Steps to Reproduce

  1. Install latest trunk version of Boost;
  2. Enable Image Guide feature;
  3. Install a plugin that allows an infinite load for images (for example Visual Portfolio, Masonry block);
  4. Open the page and scroll down so more images get loaded;
  5. The new images should not have the image guide bubble.

A clear and concise description of what you expected to happen.

Image Guide should work for dynamically loaded images as well.

What actually happened

Image Guide does not work on dynamically loaded images.

First three images are loaded on page load, the rest are on scroll.
image

Browser

Google Chrome/Chromium, Mozilla Firefox, Microsoft Edge, Apple Safari, iOS Safari, Android Chrome

Other information

No response

Platform (Simple, Atomic, or both?)

Simple

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

Currently, you can go around this by toggling the Image Guide from the admin bar on that page. Doing so will render the Image Guide for the dynamically loaded images.
image

@dilirity dilirity added [Type] Bug When a feature is broken and / or not performing as intended [Plugin] Boost A feature to speed up the site and improve performance. labels Jan 13, 2023
@dilirity dilirity added this to the Boost/1.7.0 milestone Jan 13, 2023
@pyronaur pyronaur self-assigned this Jan 13, 2023
@pyronaur
Copy link
Member

I'll tackle this Monday alongside removing the always-on feature for now.

@dilirity dilirity removed this from the Boost/1.7.0 milestone Jan 13, 2023
@pyronaur pyronaur mentioned this issue Jan 16, 2023
3 tasks
@pyronaur
Copy link
Member

Ultimately, we might want to use a mutation observer (although we could just use a timer, I'm not too excited about that solution) to see when new images appear on the page and update the image guide accordingly.

But for the first version, I think we can release this as-is and observe how often are lazy images actually a problem for people using the feature.

@github-actions
Copy link
Contributor

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@sdixon194
Copy link
Contributor

Did some more testing and looks like this one has been fixed already. Going to close the issue out, feel free to re-open if you're using it for some other kind of tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Simple [Plugin] Boost A feature to speed up the site and improve performance. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants