Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script: check for trunk/ dir in tag #28414

Closed
jeherve opened this issue Jan 17, 2023 · 1 comment · Fixed by #28437
Closed

Release script: check for trunk/ dir in tag #28414

jeherve opened this issue Jan 17, 2023 · 1 comment · Fixed by #28437
Assignees
Labels
[Status] In Progress [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Jan 17, 2023

This is a follow-up of #28400.

In some scenarios, we end up tagging a release with a copy of trunk/ inside the tag. It would be nice if this could be avoided.


We also discussed this issue here: p1673891999603519-slack-C01U2KGS2PQ

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Tools] Development CLI The tools/cli to assist during JP development. labels Jan 17, 2023
@anomiex anomiex self-assigned this Jan 18, 2023
@anomiex
Copy link
Contributor

anomiex commented Jan 18, 2023

This is an unfortunate failure mode for the recommended command to create tags in SVN. Unfortunately the recommended way to prevent this is to use a precommit hook, which as far as I can tell we can't set up on the wordpress.org SVN. Someone could create a trac ticket with them to see if they'd be willing to add it.

What we can do is have our manual script warn if someone is using it on a plugin that has auto-publish configured. We can also add a check for whether the tag already exists in SVN, but there would still be the possibility for a race.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants