Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CSS / Mobile Theme: CSS is not added to minileven #5815

Closed
jeherve opened this issue Dec 7, 2016 · 11 comments · Fixed by #14714
Closed

Custom CSS / Mobile Theme: CSS is not added to minileven #5815

jeherve opened this issue Dec 7, 2016 · 11 comments · Fixed by #14714
Assignees
Labels
[Feature] Custom CSS [Feature] Mobile Theme aka minileven [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Dec 7, 2016

Steps to reproduce the issue

  1. Start with a site using WP 4.7, JP 4.4.2, and the Mobile Theme is enabled.
  2. Go to Appearance > Edit CSS.
  3. Add some custom CSS.
  4. Save your changes.
  5. Notice the CSS loaded on your site.
  6. Load your site on mobile. Jetpack's Mobile Theme is loaded.
  7. The Custom CSS isn't loaded anywhere on mobile.

Although Minileven calls wp_head, I assume there might be a problem with the way we define the active theme with the option_stylesheet and option_template filters.

This is a big issue for all site owners who previously used Jetpack's Custom CSS module to customize the look of the Mobile Theme, thanks to the option that was provided in the Custom CSS editor to load Custom CSS on mobile as well.
Right now, the only options they have to customize that mobile theme is to edit core plugin files or create their own plugin to load a custom stylesheet.

Until this gets fixed, a quick fix is to install this little plugin:
https://github.com/jeherve/jetpack-addons/archive/mobile-custom-css.zip

Reported here:
https://wordpress.org/support/topic/site-title-color-on-jetpack-mobile-changed-after-update-it-is-not-invisible/

@jeherve jeherve added [Feature] Custom CSS [Feature] Mobile Theme aka minileven [Pri] High [Type] Bug When a feature is broken and / or not performing as intended labels Dec 7, 2016
@jeherve jeherve added this to the 4.5 milestone Dec 7, 2016
@jeherve
Copy link
Member Author

jeherve commented Dec 13, 2016

@jeherve
Copy link
Member Author

jeherve commented Dec 22, 2016

@pmciano
Copy link

pmciano commented Dec 28, 2016

Reported here: 2977121-t

@jeherve jeherve modified the milestones: 4.5, 4.5.1 Jan 17, 2017
@jeherve jeherve modified the milestones: 4.5.1, 2/17 - February, 4.7.0 - March 2017 Jan 30, 2017
@samhotchkiss samhotchkiss removed this from the 4.7.0 - March 2017 milestone Feb 3, 2017
@ebinnion
Copy link
Contributor

ebinnion commented Feb 6, 2017

Reported in 3039118-t as well.

Although Minileven calls wp_head, I assume there might be a problem with the way we define the active theme with the option_stylesheet and option_template filters.

This is happening because, with the WordPress 4.7 update, custom CSS is now stored theme specific. So, when we switch the theme to minileven WordPress is now looking for CSS changes to minileven instead of the site's usual active theme.

@danjjohnson
Copy link

Reported in 3072574-t

@brbrr
Copy link
Contributor

brbrr commented May 2, 2018

Re-tested with Jetpack 6.1. Issue is still there.

@jeherve
Copy link
Member Author

jeherve commented Mar 4, 2019

Also reported in 1844995-zen

@stale
Copy link

stale bot commented Aug 31, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Aug 31, 2019
@patsar
Copy link

patsar commented Oct 2, 2019

Any update? The problem still exists in Jetpack 7.8.

@jeherve
Copy link
Member Author

jeherve commented Oct 2, 2019

We do not have any updates at the moment, but we'll update this issue whenever we next iterate on the Mobile Theme feature in Jetpack.

Until then, I would recommend switching to a responsive theme if possible, and deactivating Jetpack's Mobile Theme feature.

@KokkieH
Copy link

KokkieH commented Nov 19, 2019

Another question related to this in https://wordpress.org/support/topic/customizing-mobile-tag-style/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Custom CSS [Feature] Mobile Theme aka minileven [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants