Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile theme: Share by email form position on mobile #6617

Closed
danjjohnson opened this issue Mar 9, 2017 · 6 comments · Fixed by #14714
Closed

Mobile theme: Share by email form position on mobile #6617

danjjohnson opened this issue Mar 9, 2017 · 6 comments · Fixed by #14714
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Mobile Theme aka minileven [Feature] Sharing Post sharing, sharing buttons [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended

Comments

@danjjohnson
Copy link

Steps to reproduce the issue

  • Enable mobile theme and sharing by email.
  • View a post on mobile and tap the share by email icon.

What I expected

The form should display within the screen boundary and should not affect the rest of the page.

What happened instead

On Android (Google Pixel), the form reduces the size of the rest of the page in order to fit on the screen:

image

On iOS, it seems that the form just overlaps the boundaries of the screen, requiring horizontal scrolling:

image

Reported in 3092923-t

@danjjohnson danjjohnson added [Feature] Mobile Theme aka minileven [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended labels Mar 9, 2017
@stale
Copy link

stale bot commented Jul 4, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@jeherve
Copy link
Member

jeherve commented May 2, 2019

Another instance in #12235 (cc @cyphix333)

@stale stale bot removed the [Status] Stale label May 2, 2019
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label May 2, 2019
@cyphix333
Copy link

Wow... not fixed after 2 years; simple issue like this, shows how much they care about fixing this one. Guess it's up to us to fix it ourselves?

@jeherve
Copy link
Member

jeherve commented May 2, 2019

@cyphix333 We're not currently working on the Email sharing button so we have no ETA for a fix right now, but if you want to contribute a fix, we'll be happy to review a Pull Request!

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Oct 29, 2019
@bikedorkjon
Copy link

This came up in 2482774-zen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Mobile Theme aka minileven [Feature] Sharing Post sharing, sharing buttons [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants