Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PHP 7.2 #8185

Closed
oskosk opened this issue Nov 16, 2017 · 1 comment
Closed

Compatibility with PHP 7.2 #8185

oskosk opened this issue Nov 16, 2017 · 1 comment
Labels

Comments

@oskosk
Copy link
Contributor

oskosk commented Nov 16, 2017

Master issue to track everything happening in Jetpack when run on PHP 7.2RC

If you want to help with a PR, please edit this description and add the PR number between parens at the end of the line

PHP Fatal errors

[ ] - Running a full Sync is totally broken when initiated from Calypso:

  Declaration of WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback($path = '', $blog_id = 0) must be compatible with WPCOM_JSON_API_Update_Post_v1_1_Endpoint::callback($path = '', $blog_id = 0, $post_id = 0)
  Type: PHP Fatal error Line: 0
  File: json-endpoints/class.wpcom-json-api-bulk-delete-post-endpoint.php

image

PHP deprecated

[ ] - Function create_function() is deprecated

Function create_function() is deprecated
Type: PHP Deprecated Line: 669
File: modules/stats.php
@oskosk
Copy link
Contributor Author

oskosk commented Nov 16, 2017

Sorry for the duplicate. Closing in favor of #8156

@oskosk oskosk closed this as completed Nov 16, 2017
@jeherve jeherve added the [Closed] Duplicate Duplicate of an existing issue. label Nov 16, 2017
@jeherve jeherve removed this from the 5.6 milestone Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants