Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: support Gallery block #8527

Closed
jeherve opened this issue Jan 15, 2018 · 10 comments
Closed

Gutenberg: support Gallery block #8527

jeherve opened this issue Jan 15, 2018 · 10 comments
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jan 15, 2018

Steps to reproduce the issue

  1. Install the Gutenberg plugin.
  2. Create a new post.
  3. Create a gallery block.
  4. There are no options to pick a gallery type during the gallery creation process. This seems to be a Gutenberg issue: Gallery: choosing thumbnail size WordPress/gutenberg#1450
  5. Once you create the gallery and publish the post, you will notice that Carousel is not triggered when clicking on the images on the front-end. That is because Gutenberg galleries use their own markup, as per Gallery block markup in the front-end WordPress/gutenberg#2900

We would need to make sure that both Tiled Galleries and Carousel can be applied to Gutenberg galleries.

Related:

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Pri] Normal labels Jan 15, 2018
@dereksmart dereksmart added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label Feb 23, 2018
@stale
Copy link

stale bot commented Aug 22, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Aug 22, 2018
@asm0dey
Copy link

asm0dey commented Aug 22, 2018

It's still valid

@stale stale bot removed the [Status] Stale label Aug 22, 2018
@abcxyz-m
Copy link

Referenced as a continuing issue here:

@MichaelArestad
Copy link
Contributor

I'm going to close this for now. We are proceeding by making a Jetpack tiled gallery block along with, potentially, a slideshow/carousel block.

@designsimply
Copy link

I searched and found #10145 is the PR for the tiled gallery block and wanted to note it here in case anyone would like to follow progress or if any testers with a dev environment would like to help test it when it's ready. 😊

@bph
Copy link

bph commented Sep 28, 2018

@designsimply - Thanks for surfacing this closed issue. It seems in Gutenberg 3.9 the Carousel is triggered when clicking on an image in the current Gutenberg Gallery Block, provided one selects "Attachment page" under "Link to" parameter. However, the Carousel doesn't have any next/previous navigation. http://recordit.co/41vNUeUrE5
Should I open a new issue, or will the fixed with the linked PR ?

@jeherve
Copy link
Member Author

jeherve commented Sep 28, 2018

@bph Thanks for the report! That seems like something we should fix on our end, by making sure the Carousel feature is compatible with the core Gallery block.

I opened #10246 to keep track of that.

@asm0dey
Copy link

asm0dey commented Dec 8, 2018

Gutenberg 4.6.1, Wordpress 5, tiled galleries still doesn't work

@jeherve
Copy link
Member Author

jeherve commented Dec 10, 2018

@asm0dey This issue is for the Carousel feature; this was implemented in Jetpack 6.8. Tiled Galleries, however, cannot be added via a block yet. That is something we are planning for Jetpack 6.9. You can follow our progress in Automattic/wp-calypso#28944

Until Jetpack 6.9 is released, I would recommend that you use the Classic block on your site, like so:

screenshot 2018-12-10 at 12 07 57

screenshot 2018-12-10 at 12 08 06

screenshot 2018-12-10 at 12 08 19

screenshot 2018-12-10 at 12 09 01

screenshot 2018-12-10 at 12 09 07

@asm0dey
Copy link

asm0dey commented Dec 10, 2018

@jeherve hah, looks funny! Thanks, will use classic editor until tiled galleries will be supported :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

7 participants