Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Carousel to work with AMP #9557

Open
gravityrail opened this issue May 15, 2018 · 2 comments · Fixed by #9458
Open

Port Carousel to work with AMP #9557

gravityrail opened this issue May 15, 2018 · 2 comments · Fixed by #9458
Labels
AMP [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@gravityrail
Copy link
Contributor

In #9458 we propose disabling Carousel as it's broken on AMP sites, primarily due to the reliance on javascript.

This issue was created to track making this feature work with AMP.

AMP has a built-in Carousel, so this shouldn't be too hard.
@gravityrail gravityrail mentioned this issue May 15, 2018
Merged
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. labels May 15, 2018
@gravityrail gravityrail reopened this May 18, 2018
@westonruter
Copy link
Contributor

I think this needs the AMP Support label.

@jeherve jeherve added the AMP label May 21, 2018
@stale
Copy link

stale bot commented Nov 17, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Nov 17, 2018
@jeherve jeherve mentioned this issue Jan 20, 2020
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AMP [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Jetpack features from breaking AMP validation with amp-wp Automattic/jetpack
4 participants
@gravityrail @westonruter @jeherve @anomiex