Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Remove usage of $HTTP_RAW_POST_DATA #9818

Closed
kraftbj opened this issue Jun 25, 2018 · 1 comment
Closed

Markdown: Remove usage of $HTTP_RAW_POST_DATA #9818

kraftbj opened this issue Jun 25, 2018 · 1 comment
Labels
[Feature] Markdown [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Jun 25, 2018

Global variable '$HTTP_RAW_POST_DATA' is deprecated since PHP 5.6 and removed since PHP 7.0; Use php://input instead is the final issue left to resolve #4346, which itself is the final step to resolve.

I'm opening this as a separate issue so we can close out 4346 to focus on the last actionable item from that conversation.

The only usage is all within one function within /modules/markdown/easy-markdown.php.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Markdown [Type] Good First Bug labels Jun 25, 2018
This was referenced Jun 25, 2018
@wigglemuff
Copy link
Contributor

The only usage is all within one function within /modules/markdown/easy-markdown.php.

This seems to be fixed in here: #9905

Here's a comment by Igor on the specific changes relevant to this issue:
#9905 (comment)

I'm closing this issue for now! If I'm wrong, reopen and let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Markdown [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug
Projects
None yet
Development

No branches or pull requests

2 participants