From 4df543df4f41c6f682ed62b0745d103572c39e4e Mon Sep 17 00:00:00 2001 From: Marin Atanasov Date: Mon, 30 Sep 2019 14:43:56 +0300 Subject: [PATCH 1/5] Admin: Load connect button scripts on dashboard and plugins --- _inc/lib/admin-pages/class.jetpack-admin-page.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/_inc/lib/admin-pages/class.jetpack-admin-page.php b/_inc/lib/admin-pages/class.jetpack-admin-page.php index 5cef91a7e2c86..8dc8d37a20758 100644 --- a/_inc/lib/admin-pages/class.jetpack-admin-page.php +++ b/_inc/lib/admin-pages/class.jetpack-admin-page.php @@ -75,6 +75,16 @@ function add_actions() { delete_transient( 'activated_jetpack' ); } + // If Jetpack not yet connected, but user is viewing one of the pages with a Jetpack connection banner. + if ( + ( 'index.php' === $pagenow || 'plugins.php' === $pagenow ) + && ! Jetpack::is_active() + && current_user_can( 'jetpack_connect' ) + && ! Jetpack::is_development_mode() + ) { + add_action( 'admin_enqueue_scripts', array( 'Jetpack_Connection_Banner', 'enqueue_connect_button_scripts' ) ); + } + // Check if the site plan changed and deactivate modules accordingly. add_action( 'current_screen', array( $this, 'check_plan_deactivate_modules' ) ); From 5bb7cea11a4e0e62f848e322d31474e16dc4903a Mon Sep 17 00:00:00 2001 From: Marin Atanasov Date: Mon, 30 Sep 2019 14:44:49 +0300 Subject: [PATCH 2/5] Connection: Add class to alt connection buttons, add connect in place URL --- class.jetpack-connection-banner.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/class.jetpack-connection-banner.php b/class.jetpack-connection-banner.php index 752aa7be1d14b..24db71cdcfca4 100644 --- a/class.jetpack-connection-banner.php +++ b/class.jetpack-connection-banner.php @@ -179,6 +179,7 @@ public static function enqueue_connect_button_scripts() { 'buttonTextRegistering' => __( 'Loading...', 'jetpack' ), 'jetpackApiDomain' => $jetpackApiUrl['scheme'] . '://' . $jetpackApiUrl['host'], 'forceVariation' => $force_variation, + 'connectInPlaceUrl' => Jetpack::admin_url( 'page=jetpack#/setup' ), 'dashboardUrl' => Jetpack::admin_url( 'page=jetpack#/dashboard' ), 'plansPromptUrl' => Jetpack::admin_url( 'page=jetpack#/plans-prompt' ), ) @@ -284,7 +285,7 @@ class="jp-wpcom-connect__hide-phone-and-smaller" + class="dops-button is-primary jp-banner__alt-connect-button"> From 1f143d35210be7a78780bf12052b04527d7a4b86 Mon Sep 17 00:00:00 2001 From: Marin Atanasov Date: Mon, 30 Sep 2019 14:45:47 +0300 Subject: [PATCH 3/5] Connection: Redirect alt connection buttons to connect in place flows --- _inc/connect-button.js | 61 +++++++++++++++++++++++++++++++----------- 1 file changed, 45 insertions(+), 16 deletions(-) diff --git a/_inc/connect-button.js b/_inc/connect-button.js index 20c51951c564d..99a8cd582211b 100644 --- a/_inc/connect-button.js +++ b/_inc/connect-button.js @@ -1,30 +1,44 @@ /* global jpConnect */ jQuery( document ).ready( function( $ ) { - var connectButton = $( '.jp-connect-button' ); + var connectButton = $( '.jp-connect-button, .jp-banner__alt-connect-button' ).eq( 0 ); var tosText = $( '.jp-connect-full__tos-blurb' ); - connectButton.click( function( event ) { + var jetpackConnectIframe = $( '