Fix GitHub action for building production version of master #13974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereksmart
added
[Type] Enhancement
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: December 3, 2019. |
mdawaffe
approved these changes
Nov 6, 2019
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
jeherve
added
the
Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes our broken master-built builds generated in the action.
https://github.com/Automattic/jetpack/actions?query=workflow%3A%22Build+production+to+master-built%22
It has no chance of breaking things further :)
Changes proposed in this Pull Request:
The action now relies pretty much entirely on the isolated published action hosted in this repo https://github.com/Automattic/action-jetpack-build-to-branch
We can now makes changes to that external repo for modifying.
I suggest we merge this and wait to see if master-built is being updated properly.
Testing instructions:
Check out the ones I tested in a separate branch, for example https://github.com/Automattic/jetpack/commit/933a9ccb92997da6ec6a443709db27238ea3ca7d/checks?check_suite_id=298902682
Does the
try/test-action-builtbranch contain a complete production build?Proposed changelog entry for your changes:
n/a