Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document 'error' event? #508

Closed
bradvogel opened this issue Feb 3, 2015 · 2 comments
Closed

Document 'error' event? #508

bradvogel opened this issue Feb 3, 2015 · 2 comments
Labels
Discussion Documentation Duplicate ready
Milestone
0.9.0

Comments

@bradvogel
Copy link

I noticed that the queue emits an 'error' event here https://github.com/LearnBoost/kue/blob/master/lib/queue/worker.js#L91. Should this be documented?
@bradvogel bradvogel changed the title Document 'error' event Document 'error' event? Feb 3, 2015
@behrad
Copy link
Collaborator

behrad commented Feb 3, 2015

actually currently all worker errors are re-emitted into kue object itself (see https://github.com/LearnBoost/kue/blob/master/lib/kue.js#L239) this is not to face uncaught exceptions when consumers forget to listen for error in each workers they create.

I considered this not a stabled decision at that time and so not added this into documentation.

@behrad behrad added this to the 0.9.0 milestone Mar 22, 2015
@behrad
Copy link
Collaborator

behrad commented Mar 22, 2015

closed by #409

@behrad behrad closed this as completed Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Documentation Duplicate ready
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@bradvogel @behrad