Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pango nightmares #570

Closed
rvagg opened this issue Jun 24, 2015 · 3 comments
Closed

Pango nightmares #570

rvagg opened this issue Jun 24, 2015 · 3 comments

Comments

@rvagg
Copy link
Contributor

rvagg commented Jun 24, 2015

I just upgraded https://nodei.co and had to yak shave my way to find a solution to my custom fonts not showing up any more. I believe related to this problem are #548 and #561. The workaround was to revert pango being enabled as it was in 7522aca at which point everything worked again.

Scanning some of the recent font related problems in the issues I wouldn't be surprised if this is biting a large number of people and perhaps we should view it as a breaking change and revert that commit (or at least pango being enabled).

@jakeg
Copy link
Contributor

jakeg commented Jun 24, 2015

Personally I'd like to see making pango a requirement.

As you say, lots of issues/frustrations have come up recently in relation to font problems, and I think part of this is that some people are installing with pango, others without, and without pango some things (e.g. fallback fonts) just aren't possible.

Is there a good reason for not making pango a requirement?

Currently we (creating printed yearbooks for hundreds of customers) use our fork of node-canvas that I haven't touched the code on since December because I know it works and I'd be very nervous about upgrading to the non-forked version with the plethora of font-related bugs I've seen lately.

@rvagg
Copy link
Contributor Author

rvagg commented Jun 24, 2015

if it's to become a requirement then we should bump major version to indicate breakage - my use is simple, load a font by pointing to a particular path and then explicitly insert that to the context and refer to it by that name - if pango become necessary then we'd need a migration path for that usage to a pango-happy usage and tbh I don't know what that is (I've messed with fontconfig to no avail)

@chearon
Copy link
Collaborator

chearon commented Mar 14, 2018

Closed via #715

@chearon chearon closed this as completed Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants