-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Themes: Editor font styles not loading in Gutenberg v9.9.3 #3280
Comments
Experienced this in the Veni theme on a customer's website in 27820699-hc. I wanted to note that this issue is present in the customizer (not only in the block editor). We can even see some oddities when we go to edit the Veni theme demo site in the customizer (not the different fonts used for the "featured pages" description texts: Versus what we see when we visit the Veni theme demo site at https://venidemo.wordpress.com/: |
This may be affecting WordPress.com/support as well. In the editor, we noticed the font now shows in a serif font, when it used to be sans-serif. |
A user reached out on chat about this too on theme Button 2. They are curious why the font size on editor suddenly got smaller. |
Reported in 17960158-hc too. |
Additional report regarding Independent Publisher 2 in 3752006-zen |
Another report here: https://wordpress.com/forums/topic/font-size-in-blocks-editor/#post-3639659 |
Another one here: hc-25451080 |
This has been reported on Twitter here: https://twitter.com/SifaPoulton/status/1372516404700790785 the theme in use is Independent Publisher 2 |
This has been reported in the forums here: https://wordpress.com/forums/topic/editor-font-randomly-changes/ the theme in use is Sela |
Reported on 28246108-hc and followed up on 3835024-zen It happens on multiple sites with multiple retired themes (i.e. Chateau, Panel) |
This has been reported in the forums here: https://wordpress.com/forums/topic/why-cant-i-choose-classical-editor-in-my-wordpress-dashboard-anymore/ the theme in use is Lodestar |
another in p1616175586038800-slack-gutenberg-on-dotcom Gutenberg: v10.2.1 |
Another report in #3839734-zen |
Another report in #3840473-zen |
👋 This is now (hot)fixed via D59109-code on Simple sites (v10.2.1). Atomic sites should receive the fix with the v10.3.0 upgrade. cc @simison |
This has been reported here: https://wordpress.com/forums/topic/post-editor-formatting-suddenly-stopped-matching-blog-format/ |
Another report #3848009-zen |
Another report: 28681526-hc / 3872799-zen |
Another instance in 29132404-hc Theme: TwoTone Editor is using a monospaced font for paragraphs which is neither displayed on their site or the theme demo |
@WunderBart just following up on this issue. It sounds like there was a fix put in place but with the ongoing reports it looks like it's not working? Is that correct? |
Hm, anything relevant in themes that might be overlaying the original issue? @jeffikus @scruffian Upstream fix was in WordPress/gutenberg#30080 and from what I can tell it wasn't reverted. |
There's another fix that's needed in Gutenberg: WordPress/gutenberg#30205 |
@fullofcaffeine, @simison - something we might consider hotfixing on Simple sites? |
@WunderBart Thanks for the ping. I looked at the PR, and I'm wary of hotfixing it on WPCOM before it gets accepted, see: WordPress/gutenberg#30205 (comment). |
@chad1008 this has come up with another user today in chat, this is what they see in the editor: and this is what they see on front end: The theme in my case is Rowling, but it seems like this is affecting several themes still. Simple site. Here is the info on my est site where I can replicate the issue: Gutenberg: v11.7.0 Is there any way this can be fixed in Gutenberg as opposed to the Themes? |
Another report of this on simple site: 4382863-zd |
+1 4383731-zd-woothemes User reported issue back in February, seems like was fixed for some time, but has popped back. |
Theme: Apostrophe 2 +1 32272678-hc |
Looks like this issue re-appearing is actually Automattic/wp-calypso#57043 I'll let the Theme team triage or close this. |
Another report in https://wordpress.com/forums/topic/very-small-font-size-again-in-the-editor/?view=all Theme: Button 2 |
Thanks for the ping @davipontesblog. There was a similar report related to the recent Gutenberg release: Automattic/wp-calypso#57043 (which I now see above, as this issue was just mentioned there yesterday ♾️ I was able to reproduce that issue in core, and reported it in WordPress/gutenberg#35730 Where this issue has been quiet since May, I'm wondering if these new cases are actually related to the other, newer issue. @oandregal has been looking into potential fixes in Gutenberg itself - ccing you here in case these additional impacted themes are helpful to know about. |
Another report: 4378950-zd-woothemes Theme: Rowling |
I'm closing this (again) in favor of Automattic/wp-calypso#57043 so we can track instances all in one location. It looks like the fix is being worked on in WordPress/gutenberg#35730 please feel free to re-open if I've done this in error. |
Steps to replicate
Many of our older themes target a classname that doesn't appear to exist anymore in the editor, which results in their font styles not being applied. Here's an example from AltoFocus:
themes/altofocus/assets/stylesheets/editor-blocks.css
Lines 22 to 28 in 3fa9d68
This targets
editor-block-list__block
, which no longer exists in Gutenberg v9.9.3 as far as I can tell. Changing it toblock-editor-block-list__block
works. (Or more preferably, these styles should be enqueued viaadd_editor_style()
and the font styles should be applied toeditor-styles-wrapper
).This is also a problem in:
Result
The editor loads the browser default for font + font size, or it uses Noto Serif.
Safari:
Chrome:
Expected
The theme should be using the Libre Baskerville font stack as specified in the stylesheet.
The text was updated successfully, but these errors were encountered: