Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Themes: Editor font styles not loading in Gutenberg v9.9.3 #3280

Closed
kjellr opened this issue Feb 15, 2021 · 35 comments
Closed

Multiple Themes: Editor font styles not loading in Gutenberg v9.9.3 #3280

kjellr opened this issue Feb 15, 2021 · 35 comments

Comments

@kjellr
Copy link
Contributor

kjellr commented Feb 15, 2021

Steps to replicate

Many of our older themes target a classname that doesn't appear to exist anymore in the editor, which results in their font styles not being applied. Here's an example from AltoFocus:

.edit-post-visual-editor .editor-block-list__block,
.editor-default-block-appender textarea.editor-default-block-appender__content {
font-size: 13.875px;
font-family: "Libre Baskerville", "Georgia", Georgia, "Times New Roman", Times, serif;
font-weight: 300;
line-height: 1.75em;
}

This targets editor-block-list__block, which no longer exists in Gutenberg v9.9.3 as far as I can tell. Changing it to block-editor-block-list__block works. (Or more preferably, these styles should be enqueued via add_editor_style() and the font styles should be applied to editor-styles-wrapper).

This is also a problem in:

Result

The editor loads the browser default for font + font size, or it uses Noto Serif.

Safari:
Screen Shot 2021-02-15 at 4 08 18 PM

Chrome:
Screen Shot 2021-02-15 at 4 11 21 PM

Expected

The theme should be using the Libre Baskerville font stack as specified in the stylesheet.

@xpurichan
Copy link

Experienced this in the Veni theme on a customer's website in 27820699-hc. I wanted to note that this issue is present in the customizer (not only in the block editor).

We can even see some oddities when we go to edit the Veni theme demo site in the customizer (not the different fonts used for the "featured pages" description texts:
Screen Shot 2021-02-17 at 2 50 59 PM

Versus what we see when we visit the Veni theme demo site at https://venidemo.wordpress.com/:
Screen Shot 2021-02-17 at 2 51 12 PM

@donalirl
Copy link

This may be affecting WordPress.com/support as well. In the editor, we noticed the font now shows in a serif font, when it used to be sans-serif.

@retnonindya
Copy link

retnonindya commented Feb 18, 2021

A user reached out on chat about this too on theme Button 2. They are curious why the font size on editor suddenly got smaller.

@fresatomica
Copy link

There are a few reports on the WordPress.com forums: here, and here.

@jamiepalatnik
Copy link

Reported in 17960158-hc too.

@noteeth
Copy link

noteeth commented Feb 20, 2021

Additional report regarding Independent Publisher 2 in 3752006-zen

@aleone89
Copy link

@nagpai nagpai added the Support label Mar 12, 2021
@vinnykaur
Copy link

Another one here: hc-25451080

@aleone89
Copy link

This has been reported on Twitter here: https://twitter.com/SifaPoulton/status/1372516404700790785 the theme in use is Independent Publisher 2

@aleone89
Copy link

This has been reported in the forums here: https://wordpress.com/forums/topic/editor-font-randomly-changes/ the theme in use is Sela

@erricgunawan
Copy link

Reported on 28246108-hc and followed up on 3835024-zen

It happens on multiple sites with multiple retired themes (i.e. Chateau, Panel)

@aleone89
Copy link

This has been reported in the forums here: https://wordpress.com/forums/topic/why-cant-i-choose-classical-editor-in-my-wordpress-dashboard-anymore/ the theme in use is Lodestar

@simison
Copy link
Member

simison commented Mar 19, 2021

another in p1616175586038800-slack-gutenberg-on-dotcom

Gutenberg: v10.2.1
https://wordpress.com/theme/nucleare

@jordesign
Copy link
Contributor

Another report in #3839734-zen
Gutenberg: v10.2.1
Theme: Baskerville 2

@lakellie
Copy link

Another report in #3840473-zen
Theme: Baskerville 2

@WunderBart
Copy link
Member

WunderBart commented Mar 22, 2021

👋 This is now (hot)fixed via D59109-code on Simple sites (v10.2.1). Atomic sites should receive the fix with the v10.3.0 upgrade. cc @simison

@aleone89
Copy link

@rinazrina
Copy link

Another report #3848009-zen
Theme: Lovecraft

@swoodipto
Copy link
Contributor

Another report: 28681526-hc / 3872799-zen
Theme: Sela (retired)

@wpericam
Copy link

Another instance in 29132404-hc

Theme: TwoTone

Editor is using a monospaced font for paragraphs which is neither displayed on their site or the theme demo

@ianstewart
Copy link
Contributor

@WunderBart just following up on this issue. It sounds like there was a fix put in place but with the ongoing reports it looks like it's not working? Is that correct?

@simison
Copy link
Member

simison commented May 4, 2021

Hm, anything relevant in themes that might be overlaying the original issue? @jeffikus @scruffian

Upstream fix was in WordPress/gutenberg#30080 and from what I can tell it wasn't reverted.

@scruffian
Copy link
Member

There's another fix that's needed in Gutenberg: WordPress/gutenberg#30205

@WunderBart
Copy link
Member

There's another fix that's needed in Gutenberg: WordPress/gutenberg#30205

@fullofcaffeine, @simison - something we might consider hotfixing on Simple sites?

@fullofcaffeine
Copy link

@WunderBart Thanks for the ping. I looked at the PR, and I'm wary of hotfixing it on WPCOM before it gets accepted, see: WordPress/gutenberg#30205 (comment).

@davipontesblog
Copy link

@chad1008 this has come up with another user today in chat, this is what they see in the editor:

Screen Shot 2021-10-15 at 2 29 42 PM

and this is what they see on front end:

Screen Shot 2021-10-15 at 2 29 24 PM

The theme in my case is Rowling, but it seems like this is affecting several themes still. Simple site. Here is the info on my est site where I can replicate the issue:

Gutenberg: v11.7.0
CoBlocks: 2.10.1
Editing Toolkit: 3.17007
WP AMP: 2.0.5

Is there any way this can be fixed in Gutenberg as opposed to the Themes?

@nicolynramos
Copy link

Another report of this on simple site: 4382863-zd
Theme: Independent Publisher 2

@formosattic
Copy link

+1 4383731-zd-woothemes
Theme: Independent Publisher 2

User reported issue back in February, seems like was fixed for some time, but has popped back.

@formosattic
Copy link

Theme: Apostrophe 2

+1 32272678-hc

@formosattic
Copy link

Looks like this issue re-appearing is actually Automattic/wp-calypso#57043

I'll let the Theme team triage or close this.

@KokkieH
Copy link

KokkieH commented Oct 20, 2021

@chad1008
Copy link

Thanks for the ping @davipontesblog. There was a similar report related to the recent Gutenberg release: Automattic/wp-calypso#57043 (which I now see above, as this issue was just mentioned there yesterday ♾️

I was able to reproduce that issue in core, and reported it in WordPress/gutenberg#35730

Where this issue has been quiet since May, I'm wondering if these new cases are actually related to the other, newer issue.

@oandregal has been looking into potential fixes in Gutenberg itself - ccing you here in case these additional impacted themes are helpful to know about.

@cuemarie
Copy link

Another report: 4378950-zd-woothemes

Theme: Rowling

@jordesign
Copy link
Contributor

I'm closing this (again) in favor of Automattic/wp-calypso#57043 so we can track instances all in one location. It looks like the fix is being worked on in WordPress/gutenberg#35730

please feel free to re-open if I've done this in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests