Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: Opt-in to support for border controls #4220

Closed
kjellr opened this issue Jul 13, 2021 · 2 comments
Closed

Blockbase: Opt-in to support for border controls #4220

kjellr opened this issue Jul 13, 2021 · 2 comments
Labels
Milestone

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2021

Blockbase should opt-in to custom border controls, as per the notes in this comment:

	"settings": {
		"defaults": {
			"border": {
				"customColor": true,
				"customRadius": true,
				"customStyle": true,
				"customWidth": true
			}
		}
	}
@kjellr kjellr added this to the Blockbase milestone Jul 13, 2021
@MaggieCabrera
Copy link
Contributor

Yeah, I thought I remembered adding these controls. The thing is not all blocks surface them the same way but these settings are already on Blockbase. You can test them on the Group block:

Screenshot 2021-07-14 at 09 30 44

@pbking
Copy link
Contributor

pbking commented Jul 14, 2021

Indeed, just tested in Quadrat too and it's working nicely as expected. Interestingly I see a slightly different panel layout that pictured above but it works smashingly. I didn't even know it was there. :P

I believe that the blocks will pick up the controls as support is expressed for them. I don't believe there's anything more to do here. It's already awesome!

Closing this as done. Please reopen if I missed something!

@pbking pbking closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants