Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videomaker: check Blockgap usage after GB change #5228

Closed
MaggieCabrera opened this issue Dec 20, 2021 · 3 comments
Closed

Videomaker: check Blockgap usage after GB change #5228

MaggieCabrera opened this issue Dec 20, 2021 · 3 comments
Labels
[Theme] Videomaker Automatically generated label for videomaker.

Comments

@MaggieCabrera
Copy link
Contributor

After WordPress/gutenberg#37459 was merged there are a few instances where we are overriding the theme's blockGap that won't work anymore:

Before After
Screenshot 2021-12-20 at 09 56 11 Screenshot 2021-12-20 at 09 55 52

It also looks like the Footer's markup is invalid, I think this is related to blockGap but not to the PR mentioned before:

Screenshot 2021-12-20 at 09 53 18
@MaggieCabrera MaggieCabrera added the [Theme] Videomaker Automatically generated label for videomaker. label Dec 20, 2021
@MaggieCabrera
Copy link
Contributor Author

Related to the patterns that use the Columns block: WordPress/gutenberg#37436

@scruffian
Copy link
Member

I don't see any issues here. Please could you confirm?

@MaggieCabrera
Copy link
Contributor Author

yeah I don't see the issues, we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Theme] Videomaker Automatically generated label for videomaker.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scruffian @MaggieCabrera