-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duotone: Overlay not showing as expected on the front end. #5259
Comments
This is likely related to this issue as well: https://github.com/wpcomvip/2u-v2/issues/1782 |
Replicated on mentioned themes, but it is not present on all (for example, Quadrant applies the Duotone correctly). |
I'm seeing the same thing on images. Tested by applying a Duotone filter to one of the images on the default page with Twenty Twenty-one. It shows up fine in the editor, but on the site itself the filter isn't there at all. Arbutus: works This user has Blank Canvas and might be complaining of the same issue. |
reported in 33405784-hc by a customer |
I'm getting another report of this in the following ticket: 4644527-zd-woothemes The domain is https://refine-artpsych.com/ and the theme is Hever. Images appear with the Duotone filter on the backend but appear differently when published. |
I found a CSS workaround for a user in 4634686-zen but only for cover blocks. Here are the relevant parts of the code I shared with them:
It probably would need to be tweaked on a per-site basis and it isn't 100% the same as the duotone effect, but it was close enough to hold them over until we have a proper fix. |
I attempted to provide a CSS fix for 4644527-zen, as they wanted duotone on image blocks.
I can't get this code to work on a simple site. I think some of the code, specifically this part below, isn't being allowed:
The code does work for me on Atomic sites though. It just requires that the duotone effect is already applied in the editor. However, this makes all of the images use the same color, and it'd be a bit of work to customize this on a per-image basis. Here's a video to show it in the customizer of my Atomic test site: atomic-duotone-workaround.mp4Note that if it is tried on a simple site, the Customizer will show a correct preview, but with the specific code I've used, the image will appear as black and white on the live site. |
Another case 4636226-zd-woothemes |
Moving the themes repo. |
Another instance of duotone failing to display outside of the editor. Site is using seedlet theme. |
Another case: 4652083-zd-woothemes with theme Illustrar. |
The core issue is here: WordPress/gutenberg#37598 |
As this isn't a core issue - I'm closing it in favour of the WP-Calypso issue we'll use to track the core issue |
Quick summary
Duotone is working properly when added to a cover block in the editor. However, when looking at the cover block on a live site duo tone is not applied at all.
Steps to reproduce
What you expected to happen
Duotone settings should be the same on the live site as they are in the editor.
What actually happened
Duotone shows one way in the editor, but is not applied on the front end.
Context
Simple, Atomic or both?
Simple
Theme-specific issue?
No response
Browser, operating system and other notes
No response
Reproducibility
Consistent
Severity
No response
Available workarounds?
No response
Workaround details
No response
The text was updated successfully, but these errors were encountered: