Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Themes: Tertiary color backgrounds are not visible on the site. #5585

Closed
devNigel opened this issue Feb 23, 2022 · 14 comments · Fixed by #5666
Closed

Multiple Themes: Tertiary color backgrounds are not visible on the site. #5585

devNigel opened this issue Feb 23, 2022 · 14 comments · Fixed by #5666
Assignees
Labels
[Pri] Normal [Type] Bug Something isn't working

Comments

@devNigel
Copy link

Quick summary

On theme Stow, when Tertiary color is set as the background color, the background color is not working. I was able to reproduce this on Simple and AT sites.

I shared a workaround and let the user know that we will update them once it is fixed.

Steps to reproduce

  1. Activate Stow theme.
  2. On the page editor, add a paragraph block.
  3. Apply the same color set as Tertiary color in Customize > Colors > Tertiary color as the background color of the block.
  4. Preview it.
  5. You will see the background color is something else.

image

image

What you expected to happen

The background color seen in editor should be visible on live page as well.the

What actually happened

The background color on the live page was different.

Context

User report: 4803117-zen

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Stow

I could not find other themes with tertiary color setting.

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

Use a slightly different color code that looks similar to Tertiary color.

@jordesign
Copy link
Contributor

I've found this to be the case on Hever as well. but not for Varia itself - so it seems specific to some child themes.
One thing I noted is that Varia does not include a Tertiary color itself - but the child themes do.

When the color is applied - a class is added to the element:

  • has-tertiary-background-color has-background, or
  • has-tertiary-color has-text-color

But then no color declaration comes in the CSS.
Maybe related to this PR: #3223

Ineraction: #4803951-zen

@jordesign jordesign transferred this issue from Automattic/wp-calypso Feb 24, 2022
@Nic-Sevic
Copy link

Nic-Sevic commented Feb 24, 2022

another instance here: 4805667-zd-woothemes
this time with the columns block

@AMcGrady
Copy link

Another instance here: 4809339-zd

Paragraph block background color not working on the Hever theme.

@AMcGrady
Copy link

Reported here: 4809827-zd
Blank Canvas theme

@AMcGrady
Copy link

Possibly related:
#4639
?

@poeticabdul
Copy link

Reported here 33966058-hc for Rockfield theme

@Gustavo-Hilario
Copy link
Contributor

Another report here: 4822858-zen

@mriyazuddin
Copy link

Another one here: 4827587-zd

@syds87
Copy link

syds87 commented Mar 7, 2022

Another one here (Blank Canvas theme): 4836622-zen

@ccwalburn
Copy link

ccwalburn commented Mar 7, 2022

Another one here: 4838881-zen
Theme: Stratford
I gave this user some CSS as a workaround:

.has-tertiary-background-color {
    background-color: #ef7f16;
}

@madhusudhand madhusudhand self-assigned this Mar 11, 2022
@mikachan mikachan changed the title Stow: Tertiary color backgrounds are not visible on the site. Multiple Themes: Tertiary color backgrounds are not visible on the site. Mar 11, 2022
@Robertght
Copy link

In my case(#4843484-zen) I used replaced C5C5C5 with c5c5c5 and it worked.

@jp-imagines
Copy link

Another report in 4879648-zd-woothemes
Theme: Hever

This CSS should fix it:

.has-tertiary-background-color {
    background: var(--wp--preset--color--tertiary);
}

...but this user is on a Personal plan. Showed them how to switch to a similar color (#C4C4C4) instead. (Robert's suggestion of #c5c5c5 instead of #C5C5C5 didn't work for me.)

@KokkieH
Copy link

KokkieH commented Mar 23, 2022

Another report for this in Hever, though with the Text Color set to the tertiary color, in a table block.

https://wordpress.com/forums/topic/word-color-from-white-turn-black/?view=all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.