Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Move the style variation specific font families from the main theme.json to the variation json file. #8079

Open
matiasbenedetto opened this issue Sep 5, 2024 · 0 comments
Labels

Comments

@matiasbenedetto
Copy link
Member

matiasbenedetto commented Sep 5, 2024

What?

Move the style variation specific font families from the main theme.json to the variation JSON file.

Why?

Currently, the font families must be defined in the main theme.json file to load as expected in the editor when the style variation is switched. If this issue WordPress/gutenberg#59965 is fixed (in progress WordPress/gutenberg#65019), we could avoid this 'hack' that's producing the printing of not needed CSS in the frontend. So, this change would be a tiny performance improvement, and it could lead to simpler-to-define typography variations.

Related

The same issue in TT5: WordPress/twentytwentyfive#233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant