-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux: Move current search string state to global state #1112
Comments
@artpi Do you suggest adding a new label for Redux work? Or maybe a new milestone? |
I got sucked into hangouts, but I promise to describe in detail :) Problem I see right now is that search string is held in URL / component - I will describe when I find a moment Filled out! |
Also: |
See also #453 |
This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏 |
I'm talking about this:
Search term for posts / pages
Currently it is held in:
?s=searchterm
This is a problem when switching sites, so I made this workaround:
https://github.com/Automattic/wp-calypso/pull/1091/files#r46399468
But I think it would be best if:
Currently, all of this feels kinda hack-y
The text was updated successfully, but these errors were encountered: