Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Disabled preview button still handles clicks #11992

Closed
marekhrabe opened this issue Mar 10, 2017 · 1 comment
Closed

Editor: Disabled preview button still handles clicks #11992

marekhrabe opened this issue Mar 10, 2017 · 1 comment

Comments

@marekhrabe
Copy link
Contributor

After merging #11536, I noticed this bug we have.

Steps to reproduce

  1. Starting at URL: /post
  2. Don't type anything and notice how the "Preview" button is disabled
  3. Click the disabled button

What I expected

I expected nothing to happen. Just like when I click the disabled publish button.

What happened instead

Preview opened and has on content. I don't mean empty post, I literally mean about:blank is loaded in the iframe.

Browser / OS version

macOS Chrome

Screenshot / Video

screen shot 2017-03-10 at 12 05 09

screen shot 2017-03-10 at 12 08 12

Context / Source

#dogfooding
@mtias
Copy link
Member

mtias commented Mar 10, 2017

I noticed this as well, we should fix it.

@mtias mtias mentioned this issue Mar 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marekhrabe @mtias