Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: actions like undo on a post with embeds auto-scrolls the post when it shouldn't #12121

Closed
ryanboren opened this issue Mar 14, 2017 · 4 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@ryanboren
Copy link
Contributor

Steps to reproduce

  1. Starting at URL: https://wordpress.com/post/
  2. Compose something in the editor that contains embeds, blockquotes, and lists
  3. Paste something
  4. Press Cmd+Z to undo
  5. Notice browser reflow that loses your vertical scroll position and sometimes your cursor position

What I expected

I expected undo to remove what I pasted without causing reflow or losing scroll and cursor position.

What happened instead

Undo lost my place. I had to scan and scroll to find where I was before undo.

Browser / OS version

Latest production versions of macOS and Chrome

Screenshot / Video

A video is available on this session note.

Context / Source

I experience #undo-reflow often in my sessions. I use undo often, particularly when accidentally pasting something with formatting intact when I meant to Shift+Cmd+z to paste and match style. Experiencing reflow and the loss of scroll and cursor position every time I undo makes for a #frustrated experience. After every undo, I have to scroll and scan my document to find where I left off, often losing my memory state and flow in the process. #scroll-scan-correlate

Related is embed reflow. #embed-reflow

@ryanboren ryanboren added the [Feature] Post/Page Editor The editor for editing posts and pages. label Mar 14, 2017
@designsimply designsimply changed the title Editor: Undo causes reflow and vscroll loss Editor: actions like undo on a post with embeds auto-scrolls the post when it shouldn't Dec 7, 2017
@designsimply
Copy link
Contributor

I was unable to reproduce the problem using the steps provided and testing with Chrome 62.0.3202.94 on Mac OS X 10.13.1.

Video: 45s

@designsimply
Copy link
Contributor

designsimply commented Dec 7, 2017

I was, however, able to reproduce the problem where adding an embed to a post that already has embeds causes the editor to scroll you out of your editing place and it's confusing when that happens.

Video: 22s

Tested with iPhone 6S, iOS 11.1.2.

@apeatling apeatling modified the milestones: Product Quality, Product Quality: Editor Flows Jan 31, 2018
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@mrfoxtalbot
Copy link

Hi! I'm performing triage on older bugs as part of the Quality Squad's efforts to cut down on backlog issue counts.

This seems to be the Calypso editor. I am closing this since we are no longer using it and there does not seem to be such an issue in the block editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

5 participants