Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Refactor and isolate logged out functionality #1326

Closed
3 tasks done
ehg opened this issue Dec 7, 2015 · 2 comments
Closed
3 tasks done

Masterbar: Refactor and isolate logged out functionality #1326

ehg opened this issue Dec 7, 2015 · 2 comments

Comments

@ehg
Copy link
Member

ehg commented Dec 7, 2015

At the moment, the Masterbar is coupled heavily to logged-in dependencies and components. This makes it both hard to reason about, and hard to server side render.

Let’s refactor the Masterbar, so it:

  • Is decoupled from logged-in and logged-out scenarios
  • Is rid of unnecessary subcomponents
  • Reads better

We should get #631 in before we start.

@mtias — do you have any refactoring tasks to add here?

@ehg
Copy link
Member Author

ehg commented Dec 21, 2015

Noting we should ES6ify and normalize the name of the StatsItem, introduced in #1894

@ockham
Copy link
Contributor

ockham commented Jan 4, 2016

Closed by #1918+#2036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants