-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a checkbox component #1430
Labels
Comments
See #5323 for updated effort. Closing this ticket as the work is tracked in the pull request. |
This was referenced Jul 10, 2020
This was referenced Aug 17, 2020
This was referenced Aug 28, 2020
This was referenced Oct 20, 2020
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Raised by @johnHackworth
Right now, most of the checkboxes in the platform are just regular
<input type="checkboxes">
, styled to use a noticon on their :before psedoselector to change how they look when checked.We should create a new react component that encapsulates the functionality and use
Gridicon
for it, avoiding CSS hacks to customize the look.It's worth noting that we already have https://github.com/Automattic/wp-calypso/tree/master/client/components/forms/form-checkbox . Maybe it would be better to just rename that component (since it's not doing anything form-related, it could become
client/components/checkbox
) and work from it. And if in the future we need any checkbox with a form-related behavior, add a newfrom-checkbox
component again.The text was updated successfully, but these errors were encountered: