Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a checkbox component #1430

Closed
lancewillett opened this issue Dec 9, 2015 · 1 comment
Closed

Create a checkbox component #1430

lancewillett opened this issue Dec 9, 2015 · 1 comment

Comments

@lancewillett
Copy link
Contributor

Raised by @johnHackworth

Right now, most of the checkboxes in the platform are just regular <input type="checkboxes">, styled to use a noticon on their :before psedoselector to change how they look when checked.

We should create a new react component that encapsulates the functionality and use Gridicon for it, avoiding CSS hacks to customize the look.

It's worth noting that we already have https://github.com/Automattic/wp-calypso/tree/master/client/components/forms/form-checkbox . Maybe it would be better to just rename that component (since it's not doing anything form-related, it could become client/components/checkbox ) and work from it. And if in the future we need any checkbox with a form-related behavior, add a new from-checkbox component again.

@lancewillett
Copy link
Contributor Author

See #5323 for updated effort. Closing this ticket as the work is tracked in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant