Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Press This missing wp-admin press-this features #1552

Open
3 tasks
designsimply opened this issue Dec 14, 2015 · 5 comments
Open
3 tasks

Editor: Press This missing wp-admin press-this features #1552

designsimply opened this issue Dec 14, 2015 · 5 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Site Settings All other general site settings. [Status] Stale [Type] Enhancement
Milestone

Comments

@designsimply
Copy link
Contributor

Raised by @rralian

The PressThis functionality in settings supports the same press-this functionality as was supported in the [BBB] editor. This is the bookmarklet in the sidebar of the [BBB] editor.

javascript:var d%3Ddocument,w%3Dwindow,e%3Dw.getSelection,k%3Dd.getSelection,x%3Dd.selection,s%3D(e%3Fe():(k)%3Fk():(x%3Fx.createRange().text:0)),f%3D%27https://wordpress.com/post/%27,l%3Dd.location,e%3DencodeURIComponent,u%3Df%2B%27%3Furl%3D%27%2Be(l.href)%2B%27%26title%3D%27%2Be(d.title)%2B%27%26text%3D%27%2Be(s)%2B%27%26v%3D4%27%3Ba%3Dfunction()%7Bif(!w.open(u,%27t%27,%27toolbar%3D0,resizable%3D1,scrollbars%3D1,status%3D1,width%3D720,height%3D570%27))l.href%3Du%3B%7D%3Bif (/Firefox/.test(navigator.userAgent)) setTimeout(a, 0)%3B else a()%3Bvoid(0)

BBB press-this

But if you use press-this pointing to wp-admin, there are some additional features. This is the bookmarklet that was previously in the settings/writing pages.

javascript:var d%3Ddocument,w%3Dwindow,e%3Dw.getSelection,k%3Dd.getSelection,x%3Dd.selection,s%3D(e%3Fe():(k)%3Fk():(x%3Fx.createRange().text:0)),f%3D%27https://example.wordpress.com/wp-admin/press-this.php%27,l%3Dd.location,e%3DencodeURIComponent,u%3Df%2B%27%3Fu%3D%27%2Be(l.href)%2B%27%26t%3D%27%2Be(d.title)%2B%27%26s%3D%27%2Be(s)%2B%27%26v%3D4%27%3Ba%3Dfunction()%7Bif(!w.open(u,%27t%27,%27toolbar%3D0,resizable%3D1,scrollbars%3D1,status%3D1,width%3D720,height%3D570%27))l.href%3Du%3B%7D%3Bif (/Firefox/.test(navigator.userAgent)) setTimeout(a, 0)%3B else a()%3Bvoid(0)

settings press-this

So it [was] a little confusing, but the bookmarklet in the sidebar [went away when we launched] the calypso editor. In 11253-gh-calypso-pre-oss we [replaced] the bookmarklet in the settings pages, with a new bookmarklet that points to calypso. However, we only support the set of features that was supported in the [BBB] editor bookmarklet. The features that we need for parity with the old wp-admin bookmarklet are:

  • scrape pressed URL for images to include in post
  • check URL for supported embed (e.g., pressing a youtube video)
  • title bar shows "Press This!"

wp-admin-press-this

Screenshot from @codebykat

In the wp-admin bookmarklet, when you click on the Add Media button, the images from the page you're sharing appear:

04a5f116-d213-11e4-8950-ea539dd1b86d

@benchilcote
Copy link

Adding here that PressThis does not generate the Post Title in Calypso Editor.
screen shot 2017-01-18 at 12 43 37 pm

@lancewillett
Copy link
Contributor

lancewillett commented May 15, 2017

Update: moved to a new issue #14882

Related but maybe a separate bug: Press This seems broken now because of the recent editor refresh in #11536

When you launch Press This now, the post editor body is hidden to the left and all you see is the right sidebar:

screen shot 2017-05-15 at 16 51 25

Here's the same window after dragging it open a bit more:
screen shot 2017-05-15 at 16 51 36

I think this was caused by #11536

@designsimply
Copy link
Contributor Author

#bug-scrub #pre-gutenburg-bug-purge

Tested and confirmed that the following are missing for Press This in Calypso:

  • Article images to include in post.
  • Supported embeds (e.g., pressing a youtube video).
  • Title bar shows "Press This!"
  • Title itself is missing.

Video: 1m59s
Tested with Firefox 58.0.1 on macOS 10.13.3.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Site Settings All other general site settings. [Status] Stale [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants