Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes Selectors: Don't convert from Immutable.js toJS() #1599

Closed
4 tasks
ockham opened this issue Dec 15, 2015 · 1 comment
Closed
4 tasks

Themes Selectors: Don't convert from Immutable.js toJS() #1599

ockham opened this issue Dec 15, 2015 · 1 comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task
Milestone
Themes: Improvements

Comments

@ockham
Copy link
Contributor

ockham commented Dec 15, 2015

As has been discussed before, Immutable.js allows for some optimizations because of its equality checks. Hence, we shouldn't be converting back toJS() or toObject() as we're now in our selectors.
Specifically, after merging #840 and #1363, we should fix the following instances:

  • themes-list#getQueryParams()
  • themes
    • getThemes()
    • getThemeById()
@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task labels Dec 15, 2015
@ockham ockham added this to the m3 milestone Dec 15, 2015
@ockham ockham mentioned this issue Dec 15, 2015
Merged
2 tasks
@ehg ehg modified the milestones: m3, Themes: Showcase M3-LoggedOut Dec 15, 2015
@ehg ehg modified the milestones: Themes: Future, Themes: Showcase M3-LoggedOut Jan 8, 2016
@ockham ockham mentioned this issue Jan 19, 2016
Merged
@ockham
Copy link
Contributor Author

ockham commented Feb 21, 2017

Fixed as part of #8785 🎉

@ockham ockham closed this as completed Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task
Projects
None yet
Milestone
Themes: Improvements
Development

No branches or pull requests
2 participants
@ockham @ehg