Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Rename client to app #2319

Closed
ehg opened this issue Jan 12, 2016 · 4 comments
Closed

Framework: Rename client to app #2319

ehg opened this issue Jan 12, 2016 · 4 comments

Comments

@ehg
Copy link
Member

ehg commented Jan 12, 2016

Since code in client/ will be used for server side rendering, as well as client side rendering. Now that we're getting rid of the shared/ dir — the name of the client/ directory is misleading. We should rename it to app.

I think we'll need to:

  • Rename client -> app
  • Find and replace client references with app
  • Update external repos that depend on the client dir, for example wp-desktop
  • Update any external docs
  • Check the semantics of the top-level directory structure. Does server make sense? How do we define app/?

@mtias have I missed anything?

@gziolo
Copy link
Member

gziolo commented Jun 8, 2017

What about this crazy idea:

  • Rename client -> src
  • Move server -> src/server
  • Keep extensions in src/extensions
  • Add src/desktop?

It would help whenever we need to use glob to search for JS files 😛

@coderkevin
Copy link
Contributor

Oh man, that would be one huge PR.

@stale
Copy link

stale bot commented Mar 6, 2018

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Mar 6, 2018
@stale stale bot closed this as completed Mar 13, 2018
@flootr
Copy link
Contributor

flootr commented Mar 14, 2018

I think this would still be nice to have. What do you think @ehg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants