Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: use a single preloader instead of two #2632

Closed
jancavan opened this issue Jan 20, 2016 · 2 comments
Closed

Stats: use a single preloader instead of two #2632

jancavan opened this issue Jan 20, 2016 · 2 comments
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Type] Enhancement

Comments

@jancavan
Copy link
Contributor

As mentioned on this PR #2491 (comment), it's odd that we're using 2 different preloaders (skeleton and spinner) all at once.

To be uniform with the rest of Calypso, we should just use the skeleton for all of the modules. The bar chart, however, could just retain the spinner.
@jancavan jancavan added [Type] Enhancement [Feature] Stats Everything related to our analytics product at /stats/ labels Jan 20, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@jancavan
Copy link
Contributor Author

I'm now only seeing the skeleton placeholder so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jancavan