Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: redux themes contains immutable.js objects #2759

Closed
gwwar opened this issue Jan 25, 2016 · 3 comments
Closed

Framework: redux themes contains immutable.js objects #2759

gwwar opened this issue Jan 25, 2016 · 3 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Framework

Comments

@gwwar
Copy link
Contributor

gwwar commented Jan 25, 2016

The themes module uses immutable.js. Mixed usage is blocking redux state persistence in #2754 since that section of the tree should be an immutable.js instance rather than a plain js object. When redux state is deserialized, you will see errors like the following:

deserialize

Inspecting reduxStore.getState().themes shows:
instance

@gwwar gwwar added this to the Calypso Core: Offline 1 milestone Jan 25, 2016
@ockham ockham added the [Feature Group] Appearance & Themes Features related to the appearance of sites. label Jan 25, 2016
@ehg
Copy link
Member

ehg commented Jan 25, 2016

Is this a bug? We're using immutable.js data structures :)

@gwwar
Copy link
Contributor Author

gwwar commented Jan 26, 2016

@ehg maybe bug is a little harsh for this one. Feel free to chime in on #2754 and comment on whether we should push for using immutable.js everywhere, allowing it on sub trees, or if we should stick with plain js objects. ;)

@gwwar gwwar changed the title Framework: redux themes contains class instances Framework: redux themes contains immutable.js objects Jan 29, 2016
@gwwar
Copy link
Contributor Author

gwwar commented Jan 30, 2016

I went ahead and persisted the themes subtree in #2754, @ehg if you have time I'd appreciate some 👀 on if I got the schemas correct in the themes subtree.

@gwwar gwwar closed this as completed Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Framework
Projects
None yet
Development

No branches or pull requests

3 participants