Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: View a theme's title and author #2875

Closed
5 of 6 tasks
ehg opened this issue Jan 28, 2016 · 3 comments
Closed
5 of 6 tasks

Themes: View a theme's title and author #2875

ehg opened this issue Jan 28, 2016 · 3 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement

Comments

@ehg
Copy link
Member

ehg commented Jan 28, 2016

Let's show the theme's title and author in an obvious manner. This is a kick-off issue, and has an emphasis on initial architecture. As always in this milestone, this needs to be server-side-renderable from the start.

TODO:

UI:
screen shot 2016-01-21 at 12 54 46
screen shot 2016-01-21 at 12 55 02

@ehg ehg added [Type] Enhancement [Feature Group] Appearance & Themes Features related to the appearance of sites. labels Jan 28, 2016
@ehg ehg added this to the Themes: Showcase M4-ThemeSheets milestone Jan 28, 2016
@ockham
Copy link
Contributor

ockham commented Jan 28, 2016

  • Theme Details 1.2 REST endpoint, which gets its data from ES.
  • Reducer/selectors/fetchers for title and author

I think we could get some working skeleton quickest if we wrote a theme-details reducer and selectors that we connect to the exisiting 1.2 endpoint (which gives us name and author) for now, and re-wire to the new Details endpoint afterwards.

@ehg
Copy link
Member Author

ehg commented Jan 28, 2016

I think we could get some working skeleton quickest if we wrote a theme-details reducer and selectors that we connect to the exisiting 1.2 endpoint (which gives us name and author) for now, and re-wire to the new Details endpoint afterwards.

Yep, I can see us going that way initially. It'd be useful to have a think about the details API early on, so we don't keep adding fields to the list endpoint.

@ehg
Copy link
Member Author

ehg commented Feb 9, 2016

I think we need to optimistically load theme details on hover in the theme list, otherwise it'll be slooow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants