Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg Publicize: Can't disable sharing to a shared social media account as an Author #10913

Closed
alisterscott opened this issue Dec 7, 2018 · 5 comments · Fixed by #10914
Closed
Assignees
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@alisterscott
Copy link
Contributor

When a social media connection is added to a simple site and is shared to an Author on the site, the author cannot disable publishing to the connection when posting content.

Steps to reproduce

  1. You will need two accounts and a single simple site: User1 is owner and administrator of the site, User2 is added to the site as an author
  2. A social media connection is added by User1 and the option to share to all administrators, editors and authors is ticked
  3. As User2 can see shared account under social settings, also can add own social media account
  4. When publishing content using Gutenberg as User2 - the shared account is listed but can't be disabled when publishing which means the user is forced to share to this social media account - this differs from the classic Calypso editor where it can be disabled

What I expected

To be able to not share content to the shared connection as an Author

What happened instead

I can't choose not to share content

Browser / OS version

Chrome and Safari macOS

Screenshot / Video

User 1 Shared Account

user 1 - shared account

User 2 can see shared account and add own account

user 2 - can see shared and add own account

In Gutenberg - Author can't disable publishing to shared account

user 2 cant disable sharing to shared account

In Calypso Classic - Author can disable publishing to shared account

user 2 can disable sharing via calypso classic

Context / Source

Manual testing new Gutenberg editor Jetpack features

@vindl
Copy link
Member

vindl commented Dec 10, 2018

@alisterscott I've removed this from Calypso Gutenberg Integration project since it's already assigned to Gutenpack. While it technically falls under the overall integration effort, it probably won't be handled by @Automattic/lannister, so I'm removing it from our board to avoid confusion.

@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

Nice catch @alisterscott!

This seems to be an API issue, so I'll transfer it to the Jetpack repo.

Also, will come up with a fix shortly.

@tyxla tyxla transferred this issue from Automattic/wp-calypso Dec 10, 2018
@tyxla tyxla self-assigned this Dec 10, 2018
@tyxla tyxla added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 10, 2018
@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

Seems like on WP.com we allow toggling the services to users with the publish_posts capability, while on Jetpack we do it for edit_others_posts capability. Since it makes sense for authors to be able to disable/enable a network before publishing, it makes sense to use publish_posts. Will file a PR in a bit.

@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

cc @mdawaffe

@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

#10914 addresses this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants