Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Settings: "Add a Custom Address" button wraps to multiple lines #3050

Closed
mattmiklic opened this issue Feb 3, 2016 · 4 comments
Closed
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Site Settings All other general site settings. [Type] Bug

Comments

@mattmiklic
Copy link
Member

The "Add a Custom Address" button on Site > Settings > General makes assumptions about the length of the button text and the width of the viewport that aren't always true. In English, the button wraps to multiple lines if the browser window is at certain widths. The button wraps to multiple lines at any width in most of the "popular languages" in Calypso.

narrow

lang

Because the height of the input matches the height of the button, it grows very large in some languages. The multiple-line button looks particularly awkward because the second line sits below the + icon on the top line. Perhaps there's a better way to float this button, or it should be displayed below the input?

@lancewillett lancewillett added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Site Settings All other general site settings. labels Apr 14, 2016
@lancewillett lancewillett changed the title "Add a Custom Address" button wraps to multiple lines Site Settings: "Add a Custom Address" button wraps to multiple lines Apr 14, 2016
@umurkontaci umurkontaci removed the [Feature Group] Emails & Domains Features related to email integrations and domain management. label May 11, 2016
@mtias mtias added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Jul 20, 2016
@lancewillett
Copy link
Contributor

Bug scrub note: reported issue is still valid. In addition, not just with long domain names or other languages — the same issue occurs in smaller screen sizes such as tablets and small laptops.

screen shot 2016-10-17 at 10 42 33

@lancewillett
Copy link
Contributor

See also a similar report (closed as duplicate): #8112

Settings: Site Address button label has a line break
Happens in viewports that are about <1065px. This causes the Site Address field to look really large:

screenshot 2016-09-16 16 09 57

@jsnmoon
Copy link
Contributor

jsnmoon commented Jun 4, 2018

I can confirm that this is still an issue. Using a default zoom, the issue occurs when the viewport is between 661px and 1051px in width.

I propose that we fix this by removing this button altogether. The action links below the disabled input already handles "Add[ing] a Custom Address", after all.

site_settings_ _site_title_ _wordpress_com

An alternative fix would be to force this form section to stack at 1040px instead of 660px as it currently does. Doing so looks like the following:

site_settings_ _site_title_ _wordpress_com

This has its tradeoffs: The interface still overflows from 1041px to 1051px and looks a bit awkward between 661px and 1040px. Nonetheless, it does prevent the button from growing vertically.

@lancewillett
Copy link
Contributor

Closing this due to inactivity. Please re-open if we decide to further improve the layout of this button.

Here are two screenshots for reference, Safari desktop on macOS.

Larger viewport
Screen Shot 2020-05-06 at 12 47 38

Smaller viewport
Screen Shot 2020-05-06 at 12 47 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Site Settings All other general site settings. [Type] Bug
Projects
None yet
Development

No branches or pull requests

6 participants