-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications: background bleed on sides of notifications in narrow views #3051
Comments
Closing because I was unable to reproduce the problem using the following testing steps:
Result: the shadow didn't go away (39s) I tested with Safari 9.1.1, Firefox 47.0.1, and Chrome 51.0.2704.106 on Mac OS X 10.11.5. |
You're right, something has changed here and the shadow seems to stick around, but I discovered a perhaps worse responsive issue with notifications: Before the browser reaches the smallest breakpoint, notifications never pop to be full-width, leaving no shadow on the left or right and letting the background bleed through: |
I can still repro the second issues Rick mentioned above. I saw it happen in Chrome on Mac at a browser width of 440 and it looks like it happens at anything above 400px (the smallest I can make Chrome) and the 48-px breakpoint when the masterbar adjusts. I've updated the title of this issue to be for the later issue we uncovered, but I'm sure it could be tweaked further for more clarity. |
This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. |
There is now a shadow. |
There is a gap between the 480 and 660 breakpoint where you can only view the single-column detail view of a notification, but you do not get a shadow to the left of the entire notifications panel. It creates this appearance:
Expected: there should always be a shadow setting notifications off the rest of the page until notifications goes fully full sreen.
cc @drw158
The text was updated successfully, but these errors were encountered: