Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: background bleed on sides of notifications in narrow views #3051

Closed
rickybanister opened this issue Feb 3, 2016 · 5 comments

Comments

@rickybanister
Copy link

There is a gap between the 480 and 660 breakpoint where you can only view the single-column detail view of a notification, but you do not get a shadow to the left of the entire notifications panel. It creates this appearance:

screen shot 2016-02-03 at 2 11 42 pm

Expected: there should always be a shadow setting notifications off the rest of the page until notifications goes fully full sreen.

cc @drw158

@lancewillett lancewillett added [Type] Janitorial [Pri] Low Address when resources are available. labels Apr 28, 2016
@designsimply
Copy link
Contributor

Closing because I was unable to reproduce the problem using the following testing steps:

  1. Start at https://wordpress.com
  2. Click the notifications icon in the top toolbar
  3. Drag the browser window so the size gets progressively smaller and check to see if the shadow setting apart the notifications panel goes away at any point

Result: the shadow didn't go away (39s)

I tested with Safari 9.1.1, Firefox 47.0.1, and Chrome 51.0.2704.106 on Mac OS X 10.11.5.

@rickybanister
Copy link
Author

You're right, something has changed here and the shadow seems to stick around, but I discovered a perhaps worse responsive issue with notifications:

Before the browser reaches the smallest breakpoint, notifications never pop to be full-width, leaving no shadow on the left or right and letting the background bleed through:

screen shot 2016-08-09 at 11 01 17 am

@rickybanister rickybanister reopened this Aug 9, 2016
@lancewillett lancewillett removed the [Pri] Low Address when resources are available. label Oct 17, 2016
@kriskarkoski kriskarkoski changed the title Notifications: single column detail view has no shadow Notifications: background bleed on sides of notifications in narrow views Oct 31, 2016
@kriskarkoski
Copy link
Contributor

I can still repro the second issues Rick mentioned above. I saw it happen in Chrome on Mac at a browser width of 440 and it looks like it happens at anything above 400px (the smallest I can make Chrome) and the 48-px breakpoint when the masterbar adjusts.

I've updated the title of this issue to be for the later issue we uncovered, but I'm sure it could be tweaked further for more clarity.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@davewhitley
Copy link
Contributor

There is now a shadow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants