Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighter Block: end tag closing bracket is improperly converted to encoded bracket #34931

Closed
supernovia opened this issue Jul 26, 2019 · 14 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug

Comments

@supernovia
Copy link
Contributor

supernovia commented Jul 26, 2019

Steps to reproduce

  1. Add a Syntax Highlighter Block
  2. Paste code for an HTML image
  3. View the results

What I expected

I want the document to display the correct code, like this:

<img src="x.gif" alt="x" />

What happened instead

We display this:
<img src="x.gif" alt="x" /&gt;

Browser / OS version

Any

Screenshot / Video

Screen Shot 2019-07-26 at 2 33 01 PM

Screen Shot 2019-07-26 at 2 34 59 PM

Context / Source

https://en.forums.wordpress.com/topic/html-header/

At first I thought the images must be broken because the user was copying and pasting and the images didn't work. Then I realized it's actually the way our code displays. D'oh.

@lancewillett lancewillett changed the title Syntax Highlighter Block: Syntax Highlighter Block: end tag closing bracket is improperly converted to encoded bracket Jul 29, 2019
@lancewillett lancewillett added [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug labels Jul 29, 2019
@nerdysandy
Copy link
Contributor

Reported on #2261705-zen

@sanjeev00733
Copy link

Another report in 12853603-hc

@gwensmithx
Copy link

gwensmithx commented Sep 19, 2019

Another report - 2357161-ZD

Trying to add <orderItems>(); and it's showing as:
Screen Shot 2019-09-19 at 8 39 52 AM

UPDATE: Followed up via new ticket - 2493464-zd

@abatishchev
Copy link

After multiple reports are there any plans to finally fix it by addressing the underlying defect in the code?

@ajaykj
Copy link

ajaykj commented Oct 1, 2019

I have another user reporting this in 14220674-hc. Are there any alternatives? Also, seems like the same issue is reported in #34826

@mrfoxtalbot
Copy link

I have another instance here 2394809-zen. In this case I suggested using the regular code block or the pre block as a suboptimal, but practical, workaround.

@gwensmithx
Copy link

gwensmithx commented Oct 3, 2019

Another instance here: 2372729-zd.

UPDATE: follow-up via new ticket 2493475-zd

@AtrumGeost
Copy link
Contributor

I'm seeing the same on our own support documents:

https://en.support.wordpress.com/links/email-links/

Changing those blocks to "Code" for now until this bug is fixed

@kriskorn
Copy link
Contributor

Another report in 2432704-zen.

@fresatomica
Copy link

@abatishchev
Copy link

Hey folks, when exactly this shit will be fixed? I'm not renewing my annual subscription if it's not by EoY. There are so many small issues with the WP.com software that I don't know why I'm continuing paying you.

@ahmadbaig1
Copy link

Another report here- 2463182-zen

@gwwar
Copy link
Contributor

gwwar commented Nov 5, 2019

Potentially related WordPress/gutenberg#17994

@mkaz
Copy link
Contributor

mkaz commented Nov 6, 2019

This was fixed on WordPress.com today by merging this fix.
Automattic/syntaxhighlighter#3

The plugin will still need an update and a deploy.

@mkaz mkaz closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug
Projects
None yet
Development

No branches or pull requests