Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: 2FA: when re-enabling 2FA previous phone number is shown but buttons are not clickable #387

Closed
v18 opened this issue Nov 21, 2015 · 3 comments
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Bug [Type] Janitorial

Comments

@v18
Copy link
Contributor

v18 commented Nov 21, 2015

Steps to reproduce:

  1. Add 2FA to an account
  2. Remove 2FA for that account
  3. Try to add 2FA again. Here's what you see:

screen shot 2015-11-21 at 10 09 42 am

The buttons are disabled:

button-html

By typing another number in the phone field, the buttons are re-enabled:

re-enabled

This behaviour is correct when there isn't a phone number already saved in the phone field. When there is already a number saved there, the buttons should be available right away (one exception is in the case where it's been less than 1 minute since the last SMS for the SMS button).

The buttons should not be only reenabled when more text is typed or erased from the field.

@v18 v18 added [Type] Bug [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Janitorial labels Nov 21, 2015
@ebinnion
Copy link
Contributor

After looking into this, I think the best way to approach this would be to refactor the component. Specifically, at least factoring out the getValue functionality so that we could build a phoneNumber object in the getInitialState lifecycle method of Security2faSettings.

I would prefer to tackle this in a maintenance period in December so that I can focus on people management, unless this is crucial to address right now. Also ping @mjangda who might have some bandwidth to address this sooner.

cc @beaulebens @designsimply

@v18
Copy link
Contributor Author

v18 commented Nov 30, 2015

This is related to #26 - both buttons can become disabled when cancelling the process and starting again

@ebinnion
Copy link
Contributor

This should be fixed in #584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Bug [Type] Janitorial
Projects
None yet
Development

No branches or pull requests

3 participants