Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Custom Font size does not work #47584

Closed
poojashetty18 opened this issue Nov 19, 2020 · 6 comments
Closed

Navigation Block: Custom Font size does not work #47584

poojashetty18 opened this issue Nov 19, 2020 · 6 comments
Assignees
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Normal Schedule for the next available opportuinity. [Type] Bug

Comments

@poojashetty18
Copy link

Steps to reproduce

  1. Start by adding a Navigation block to any page or post
  2. Update the font size to custom size
  3. The changes are reflected in the Editor but no on the actual page

Browser / OS version

Tested it on Chrome. I tried switching to multiple themes but the issue is the same across themes

Screenshot / Video

On Editor side: Screenshot on 2020-11-19 at 16-40-12

On Actual page:
Screenshot on 2020-11-19 at 16-52-20

Context / Source

User report on 3494221-zd

@cathymcbride cathymcbride added [Type] Bug Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Normal Schedule for the next available opportuinity. labels Nov 19, 2020
@cathymcbride
Copy link
Contributor

possibly related to : p59oML-1Km-p2 ?

@jeyip jeyip assigned jeyip and unassigned jeyip Nov 20, 2020
@jeyip
Copy link
Contributor

jeyip commented Nov 20, 2020

Issue confirmed for simple and atomic sites in Chrome, Firefox, Safari, and Edge 👍 Moving this into the backlog.

@jeyip
Copy link
Contributor

jeyip commented Nov 20, 2020

For some odd reason, when inline font size styles are applied to the nav element, the px suffix is stripped from the font-size value.

Screen Shot 2020-11-20 at 12 10 07 PM

@alshakero
Copy link
Member

For some odd reason, when inline font size styles are applied to the nav element, the px suffix is stripped from the font-size value.

Interestingly, I'm getting the opposite problem

image

@alshakero
Copy link
Member

This seems to fixed in WordPress/gutenberg#26762, released in GB 9.4.0. Took me a whole day to figure out because I couldn't reproduce locally.

@jeyip can you by any chance confirm this is no longer an issue in 9.4.0? I can't reproduce locally on (GB#master) but some confirmation would be super helpful.

@alshakero alshakero self-assigned this Dec 2, 2020
@cathymcbride
Copy link
Contributor

I'm not seeing it in GB 9.4.1. Closing....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Normal Schedule for the next available opportuinity. [Type] Bug
Projects
None yet
Development

No branches or pull requests

4 participants